Skip to content

refactor(test): extract assertStatus helper to testutil - #178

Closed
jackby03 wants to merge 1 commit into
mainfrom
refactor/extract-assert-status-helper-5934071554595623506
Closed

jackby03 wants to merge 1 commit into
mainfrom
refactor/extract-assert-status-helper-5934071554595623506

Conversation

@jackby03

Copy link
Copy Markdown
Owner

This PR extracts the duplicate assertStatus helper function previously copied across 11 module test files into internal/modules/util/testutil.

🎯 What

Extracted assertStatus to testutil.AssertStatus(t, findings, id, want) and removed duplicated implementations in auditd, containers, crypto, firewall, logging, mac, network, ntp, ssh, updates, and users module test files. Added unit test coverage for testutil.AssertStatus.

💡 Why

Deduplicating test helper functions improves code health, readability, and maintainability across module unit tests.

✅ Verification

  • Added unit tests in internal/modules/util/testutil/testutil_test.go verifying AssertStatus.
  • Ran go test ./... and confirmed all tests compile and pass cleanly.

✨ Result

Code base duplicate helper logic eliminated and replaced with shared testutil.AssertStatus.


PR created automatically by Jules for task 5934071554595623506 started by @jackby03

Extract duplicate assertStatus test helpers across module test files into a shared testutil.AssertStatus helper function.

Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@jackby03 jackby03 closed this Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant