Repository navigation
Conversation
Extract duplicate assertStatus test helpers across module test files into a shared testutil.AssertStatus helper function. Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR extracts the duplicate
assertStatushelper function previously copied across 11 module test files intointernal/modules/util/testutil.🎯 What
Extracted
assertStatustotestutil.AssertStatus(t, findings, id, want)and removed duplicated implementations inauditd,containers,crypto,firewall,logging,mac,network,ntp,ssh,updates, andusersmodule test files. Added unit test coverage fortestutil.AssertStatus.💡 Why
Deduplicating test helper functions improves code health, readability, and maintainability across module unit tests.
✅ Verification
internal/modules/util/testutil/testutil_test.goverifyingAssertStatus.go test ./...and confirmed all tests compile and pass cleanly.✨ Result
Code base duplicate helper logic eliminated and replaced with shared
testutil.AssertStatus.PR created automatically by Jules for task 5934071554595623506 started by @jackby03