Skip to content

🧹 refactor(testutil): share assertStatus test helper across modules - #176

Merged
jackby03 merged 1 commit into
mainfrom
refactor/dedup-assert-status-helper-2926007565781780899
Aug 29, 2026
Merged

jackby03 merged 1 commit into
mainfrom
refactor/dedup-assert-status-helper-2926007565781780899

Conversation

@jackby03

Copy link
Copy Markdown
Owner

🧹 [refactor assertStatus test helper]

🎯 What: Extracted duplicate assertStatus test helper functions from 11 module test files into testutil.AssertStatus in internal/modules/util/testutil/testutil.go.

💡 Why: Removing duplicate code across module test files reduces boilerplates and simplifies future updates to check finding assertion logic.

✅ Verification: Added TestAssertStatus test coverage in testutil_test.go and verified all tests pass across internal/modules/... and ./....

✨ Result: Improved test maintainability and code health without changing runtime or test behavior.


PR created automatically by Jules for task 2926007565781780899 started by @jackby03

Extract assertStatus to internal/modules/util/testutil and update all
11 module test files to use testutil.AssertStatus, removing duplicated
local helpers and improving maintainability.

Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@jackby03
jackby03 merged commit a5aed29 into main Aug 29, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant