Skip to content

🧹 refactor(test): deduplicate assertStatus helper across modules - #175

Closed
jackby03 wants to merge 1 commit into
mainfrom
refactor/deduplicate-assert-status-helper-888092796735898172
Closed

jackby03 wants to merge 1 commit into
mainfrom
refactor/deduplicate-assert-status-helper-888092796735898172

Conversation

@jackby03

Copy link
Copy Markdown
Owner

🧹 What:
Extracted duplicate assertStatus test helper functions from 11 module test files (updates, crypto, auditd, network, ntp, containers, users, firewall, mac, logging, ssh) into a shared testutil.AssertStatus function in internal/modules/util/testutil.

💡 Why:
Removes repetitive code across test suites and simplifies maintenance of test status assertions.

✅ Verification:
Ran unit tests across all module packages (go test -count=1 ./internal/modules/...) and verified all tests compile and pass cleanly. Added a dedicated unit test in internal/modules/util/testutil/testutil_test.go.

✨ Result:
Improved maintainability and code health without altering module or test behavior.


PR created automatically by Jules for task 888092796735898172 started by @jackby03

Extract the duplicate assertStatus test helper function across 11 module
test files into testutil.AssertStatus. Added test coverage for the helper
in testutil_test.go.

Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@jackby03 jackby03 closed this Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant