Skip to content

🧹 refactor(testutil): extract duplicate assertStatus helper - #174

Closed
jackby03 wants to merge 1 commit into
mainfrom
refactor/extract-assert-status-helper-17582178743756889352
Closed

jackby03 wants to merge 1 commit into
mainfrom
refactor/extract-assert-status-helper-17582178743756889352

Conversation

@jackby03

Copy link
Copy Markdown
Owner

🧹 Extract duplicate assertStatus test helper function across module test files into internal/modules/util/testutil.

🎯 What: Extracted duplicate assertStatus function definitions from module test files (mac, auditd, containers, crypto, firewall, logging, network, ntp, ssh, updates, users) into testutil.AssertStatus in package internal/modules/util/testutil.

💡 Why: Reduces code duplication across unit tests and simplifies maintainability when updating finding assertion behavior.

✅ Verification: Added unit tests in internal/modules/util/testutil/testutil_test.go and verified all tests across internal/modules/... pass.

✨ Result: Cleaned up duplicate code across 11 test files and centralized test finding assertions in a shared package.


PR created automatically by Jules for task 17582178743756889352 started by @jackby03

… package

Extract duplicate assertStatus test helper function from individual module
test files into the shared internal/modules/util/testutil package as
testutil.AssertStatus.

Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@jackby03 jackby03 closed this Aug 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant