Skip to content

🔒 fix(fleet): use mktemp for unpredictable temporary report file path - #168

Merged
jackby03 merged 2 commits into
mainfrom
fix/predictable-temp-file-fleet-8346812920574847013
Aug 29, 2026
Merged

jackby03 merged 2 commits into
mainfrom
fix/predictable-temp-file-fleet-8346812920574847013

Conversation

@jackby03

Copy link
Copy Markdown
Owner

🎯 What: Replaced predictable timestamp-based temporary file creation (/tmp/hardbox-fleet-%d.json) in internal/fleet/fleet.go with mktemp /tmp/hardbox-fleet-XXXXXX executed on target remote systems via SSH.

⚠️ Risk: Constructing predictable temporary file names in /tmp using timestamps opens a window for symlink attacks, race conditions, or unprivileged local user tampering with audit report files prior to or during writing on the host.

🛡️ Solution: mktemp generates unpredictable temporary file paths with restricted permissions (0600). Deferred file cleanup ensures the report file is removed regardless of audit success or failure.


PR created automatically by Jules for task 8346812920574847013 started by @jackby03

Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
@jackby03
jackby03 merged commit a2614c9 into main Aug 29, 2026
11 checks passed
@jackby03
jackby03 deleted the fix/predictable-temp-file-fleet-8346812920574847013 branch August 29, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant