Repository navigation
🔒 fix(fleet): use mktemp for unpredictable temporary report file path - #168
Conversation
Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: jackby03 <70082129+jackby03@users.noreply.github.com>
🎯 What: Replaced predictable timestamp-based temporary file creation (
/tmp/hardbox-fleet-%d.json) ininternal/fleet/fleet.gowithmktemp /tmp/hardbox-fleet-XXXXXXexecuted on target remote systems via SSH./tmpusing timestamps opens a window for symlink attacks, race conditions, or unprivileged local user tampering with audit report files prior to or during writing on the host.🛡️ Solution:
mktempgenerates unpredictable temporary file paths with restricted permissions (0600). Deferred file cleanup ensures the report file is removed regardless of audit success or failure.PR created automatically by Jules for task 8346812920574847013 started by @jackby03