fix(safety): trigger guard on partial extraction#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/classify-touched-paths.sh: filters dependency-relevant paths down to thoseextract-deps.shdoes NOT parse.dependency-cooldown.ymlanddependency-safety.yml.Why
A grouped Dependabot PR mixing a supported file (e.g.
uv.lock) and an unsupported one (e.g.package-lock.json) was bypassing the existing fail-loud guard:DEPS_TSVwas non-empty (from the supported file), so the guard'sif [ -z DEPS_TSV ]gate skipped, and the unsupported file's dep-relevant changes were silently ignored — the gate could resolve tosuccessandauto_merge_ok=true.This is the same failure shape as #52 but for partial extraction rather than empty extraction.
Test plan
bats tests/classify-touched-paths.bats(24 helper unit cases)bats tests/dep-guard-chain.bats(5 chain integration cases including Fail-loud guard should fire on partial-extraction (mixed supported/unsupported lockfiles) #62 repro)bats tests/guard-shape.bats(5 workflow YAML shape assertions)bats tests/(full local suite)./scripts/check-inline-sync.sh(12 OK lines)./scripts/lint-workflow-call.shFixes #62.