Skip to content

Remove config-tracking cache bootstrap - #2621

Open
j178 wants to merge 1 commit into
drop-max-concurrencyfrom
drop-tracking-bootstrap
Open

Remove config-tracking cache bootstrap#2621
j178 wants to merge 1 commit into
drop-max-concurrencyfrom
drop-tracking-bootstrap

Conversation

@j178

@j178 j178 commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Removes the one-time config-tracking bootstrap from the workspace discovery cache.

Copilot AI lite review requested due to automatic review settings August 26, 2026 13:18
@j178 j178 added internal Internal changes breaking Breaking changes labels Aug 26, 2026
Copilot AI reviewed Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Aug 26, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1b8726b1bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/prek/src/store.rs
match fs_err::read_to_string(&tracking_file) {
Err(e) if e.kind() == std::io::ErrorKind::NotFound => {}
Err(e) => return Err(e.into()),
Err(e) if e.kind() == std::io::ErrorKind::NotFound => Ok(FxHashSet::default()),

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve configs discovered before tracking starts

When config-tracking.json is absent but workspace caches already exist, returning an empty set here causes the next run or exec to write only its own selected configs. Other entry points, notably install --install-hooks through prepare_hooks, initialize repositories and hook environments and save a workspace cache without calling track_configs; after a run in another workspace creates the tracking file, cache gc treats those still-used resources as unreferenced and removes them. Preserve the migration seeding or make every resource-producing path track its configs before removing it.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.99%. Comparing base (eedda1b) to head (e804c97).

Files with missing lines Patch % Lines
crates/prek/src/store.rs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           drop-max-concurrency    #2621      +/-   ##
========================================================
+ Coverage                 92.53%   93.99%   +1.45%     
========================================================
  Files                       140      140              
  Lines                     29578    29534      -44     
========================================================
+ Hits                      27371    27761     +390     
+ Misses                     2207     1773     -434

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@j178
j178 force-pushed the drop-tracking-bootstrap branch from 1b8726b to e804c97 Compare August 26, 2026 13:26
@j178
j178 force-pushed the drop-max-concurrency branch from 9275cc1 to eedda1b Compare August 26, 2026 13:26
@prek-ci-bot

prek-ci-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

📦 Cargo Bloat Comparison

.text size change: +0.00% (12.5 MiB → 12.5 MiB)

Expand for cargo-bloat output

Head Branch Results

File  .text     Size             Crate Name
0.1%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_44_0_aes_gcm_encrypt_avx512
0.1%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_44_0_aes_gcm_decrypt_avx512
0.0%   0.9% 113.7KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  51.4KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.4%  48.7KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.3%  44.6KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  44.5KiB              prek prek::run::{closure#0}
0.0%   0.3%  37.1KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  33.8KiB              prek <prek::languages::rust::rust::Rust as prek::languages::LanguageBackend>::install::{closure#0}
0.0%   0.3%  33.6KiB              prek prek::cli::run::run::run::{closure#0}
0.0%   0.2%  28.6KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.4KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_44_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.8KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_44_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.4KiB              toml <toml::de::deserializer::value::ValueDeserializer as serde_core::de::Deserializer>::deserialize_any::<<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor>
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
4.2%  86.6%  10.8MiB                   And 20255 smaller methods. Use -n N to show more.
4.9% 100.0%  12.5MiB                   .text section size, the file size is 256.6MiB

Base Branch Results

File  .text     Size             Crate Name
0.1%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_44_0_aes_gcm_encrypt_avx512
0.1%   2.6% 332.0KiB        aws_lc_sys aws_lc_0_44_0_aes_gcm_decrypt_avx512
0.0%   0.9% 113.8KiB              prek <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
0.0%   0.4%  51.4KiB              prek <<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.4%  48.7KiB annotate_snippets annotate_snippets::renderer::render::render
0.0%   0.3%  44.6KiB              prek <<prek::config::Config as serde_core::de::Deserialize>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::<<serde_saphyr::de::deserializer::YamlDeserializer as serde_core::de::Deserializer>::deserialize_map::MA>
0.0%   0.3%  36.8KiB              prek prek::run::{closure#0}
0.0%   0.3%  36.7KiB              prek <prek::cli::RunOptions as clap_builder::derive::Args>::augment_args
0.0%   0.3%  35.3KiB              prek <prek::languages::rust::rust::Rust as prek::languages::LanguageBackend>::install::{closure#0}
0.0%   0.3%  33.4KiB              prek prek::cli::run::run::run::{closure#0}
0.0%   0.2%  28.6KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  28.6KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  28.0KiB        aws_lc_sys aws_lc_0_44_0_edwards25519_scalarmuldouble_alt
0.0%   0.2%  27.8KiB      serde_saphyr <granit_parser::scanner::Scanner<granit_parser::input::str::StrInput>>::fetch_more_tokens
0.0%   0.2%  27.5KiB        aws_lc_sys aws_lc_0_44_0_edwards25519_scalarmuldouble
0.0%   0.2%  27.4KiB              toml <toml::de::deserializer::value::ValueDeserializer as serde_core::de::Deserializer>::deserialize_any::<<prek::config::hook::HookWire as serde_core::de::Deserialize>::deserialize::__Visitor>
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  27.0KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
0.0%   0.2%  26.9KiB              prek prek::archive::unpack::<fs_err::tokio::file::File, &std::path::PathBuf>::{closure#0}
4.2%  86.7%  10.8MiB                   And 20265 smaller methods. Use -n N to show more.
4.9% 100.0%  12.5MiB                   .text section size, the file size is 256.8MiB

@prek-ci-bot

prek-ci-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

⚡️ Hyperfine Benchmarks

Summary: 0 regressions, 0 improvements above the 10% threshold.

Environment
  • OS: Linux 6.17.0-1022-azure
  • CPU: 4 cores
  • prek version: prek 0.4.14+32 (36b1362 2026-08-26)
  • Rust version: rustc 1.98.0 (88d9e12ae 2026-08-18)
  • Hyperfine version: hyperfine 1.20.0
CLI Commands

Benchmarking basic commands in the main repo:

prek --version

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base --version 2.3 ± 0.1 2.1 3.0 1.06 ± 0.08
prek-head --version 2.1 ± 0.1 2.0 2.6 1.00

prek list

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base list 9.3 ± 0.4 8.9 11.3 1.00
prek-head list 9.4 ± 0.3 9.0 10.5 1.00 ± 0.05

prek validate-config .pre-commit-config.yaml

⏭️ Skipped: .pre-commit-config.yaml not found

prek sample-config

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base sample-config 2.7 ± 0.2 2.4 3.2 1.07 ± 0.09
prek-head sample-config 2.5 ± 0.1 2.4 3.1 1.00
Cold vs Warm Runs

Comparing first run (cold) vs subsequent runs (warm cache):

prek run --all-files (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 41.1 ± 1.8 38.0 43.3 1.01 ± 0.05
prek-head run --all-files 40.6 ± 1.2 38.5 42.1 1.00

prek run --all-files (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 40.4 ± 1.0 38.4 42.1 1.01 ± 0.04
prek-head run --all-files 40.0 ± 1.0 38.6 42.2 1.00
Full Hook Suite

Running the builtin hook suite on the benchmark workspace:

prek run --all-files (full builtin hook suite)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --all-files 40.1 ± 1.4 37.5 43.1 1.00
prek-head run --all-files 40.3 ± 1.1 37.4 42.9 1.00 ± 0.04
Individual Hook Performance

Benchmarking each hook individually on the test repo:

prek run trailing-whitespace --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run trailing-whitespace --all-files 13.6 ± 0.3 13.1 14.2 1.01 ± 0.04
prek-head run trailing-whitespace --all-files 13.4 ± 0.4 12.3 14.3 1.00

prek run end-of-file-fixer --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run end-of-file-fixer --all-files 11.4 ± 0.6 10.6 13.2 1.00
prek-head run end-of-file-fixer --all-files 11.4 ± 0.5 10.6 12.7 1.01 ± 0.07

prek run check-json --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-json --all-files 8.0 ± 0.3 7.4 8.8 1.00 ± 0.05
prek-head run check-json --all-files 7.9 ± 0.3 7.4 8.4 1.00

prek run check-yaml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-yaml --all-files 7.8 ± 0.2 7.4 8.0 1.01 ± 0.03
prek-head run check-yaml --all-files 7.7 ± 0.2 7.4 8.2 1.00

prek run check-toml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-toml --all-files 7.9 ± 0.3 7.4 8.8 1.00
prek-head run check-toml --all-files 7.9 ± 0.3 7.5 8.4 1.00 ± 0.05

prek run check-xml --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-xml --all-files 7.6 ± 0.3 7.2 8.8 1.00
prek-head run check-xml --all-files 7.7 ± 0.4 7.1 8.8 1.01 ± 0.07

prek run detect-private-key --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run detect-private-key --all-files 11.1 ± 0.5 10.2 12.2 1.00
prek-head run detect-private-key --all-files 11.2 ± 0.5 10.7 13.0 1.01 ± 0.07

prek run fix-byte-order-marker --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run fix-byte-order-marker --all-files 13.0 ± 0.8 11.9 14.8 1.00
prek-head run fix-byte-order-marker --all-files 13.4 ± 0.8 12.1 15.4 1.03 ± 0.09
Installation Performance

Benchmarking hook installation (fast path hooks skip Python setup):

prek install-hooks (cold - no cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.6 ± 0.1 4.5 4.7 1.04 ± 0.03
prek-head install-hooks 4.4 ± 0.1 4.3 4.4 1.00

prek install-hooks (warm - with cache)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base install-hooks 4.4 ± 0.1 4.4 4.6 1.00
prek-head install-hooks 4.6 ± 0.1 4.4 4.8 1.03 ± 0.04
File Filtering/Scoping Performance

Testing different file selection modes:

prek run (staged files only)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run 24.4 ± 0.4 23.8 25.3 1.00 ± 0.03
prek-head run 24.3 ± 0.5 23.7 25.6 1.00

prek run --files '*.json' (specific file type)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --files '*.json' 5.3 ± 0.1 5.1 5.6 1.00
prek-head run --files '*.json' 5.3 ± 0.2 5.1 5.8 1.01 ± 0.04
Workspace Discovery & Initialization

Benchmarking hook discovery and initialization overhead:

prek run --dry-run --all-files (measures init overhead)

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run --dry-run --all-files 6.9 ± 0.1 6.7 7.1 1.00
prek-head run --dry-run --all-files 7.0 ± 0.2 6.8 7.5 1.02 ± 0.03
Meta Hooks Performance

Benchmarking meta hooks separately:

prek run check-hooks-apply --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-hooks-apply --all-files 8.2 ± 0.1 8.1 8.4 1.00
prek-head run check-hooks-apply --all-files 8.5 ± 0.3 8.1 9.2 1.03 ± 0.04

prek run check-useless-excludes --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run check-useless-excludes --all-files 8.1 ± 0.1 7.9 8.2 1.00
prek-head run check-useless-excludes --all-files 8.2 ± 0.2 8.0 8.5 1.01 ± 0.02

prek run identity --all-files

Command Mean [ms] Min [ms] Max [ms] Relative
prek-base run identity --all-files 7.0 ± 0.1 6.9 7.1 1.00
prek-head run identity --all-files 7.4 ± 0.3 7.1 8.0 1.06 ± 0.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

breaking Breaking changes internal Internal changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j178