Remove legacy update aliases - #2619
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8bd72331f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8bd7233 to
fd44aab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2619 +/- ##
=======================================
Coverage 93.96% 93.97%
=======================================
Files 140 140
Lines 29639 29679 +40
=======================================
+ Hits 27850 27890 +40
Misses 1789 1789 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat Comparison
Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 1 regressions, 0 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.4 ± 0.1 | 2.2 | 2.7 | 1.05 ± 0.06 |
prek-head --version |
2.3 ± 0.1 | 2.2 | 2.6 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
9.6 ± 0.1 | 9.3 | 10.1 | 1.00 |
prek-head list |
9.9 ± 0.3 | 9.6 | 11.6 | 1.03 ± 0.03 |
prek validate-config .pre-commit-config.yaml
⏭️ Skipped: .pre-commit-config.yaml not found
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.7 ± 0.0 | 2.6 | 2.8 | 1.00 |
prek-head sample-config |
2.7 ± 0.2 | 2.5 | 3.8 | 1.00 ± 0.07 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
40.6 ± 5.5 | 36.6 | 53.6 | 1.04 ± 0.14 |
prek-head run --all-files |
38.9 ± 0.9 | 38.1 | 40.9 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
37.8 ± 0.9 | 36.1 | 39.9 | 1.00 |
prek-head run --all-files |
42.3 ± 8.1 | 35.7 | 70.4 | 1.12 ± 0.22 |
prek run --all-files (warm - with cache): 11.9900% slower
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
38.3 ± 1.3 | 35.5 | 41.5 | 1.01 ± 0.05 |
prek-head run --all-files |
38.1 ± 1.2 | 36.2 | 41.7 | 1.00 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
12.8 ± 0.4 | 12.1 | 13.8 | 1.00 |
prek-head run trailing-whitespace --all-files |
13.2 ± 0.7 | 12.3 | 14.5 | 1.03 ± 0.06 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
11.5 ± 0.5 | 10.6 | 12.5 | 1.01 ± 0.05 |
prek-head run end-of-file-fixer --all-files |
11.4 ± 0.4 | 10.8 | 12.3 | 1.00 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
8.2 ± 0.3 | 7.7 | 8.7 | 1.02 ± 0.05 |
prek-head run check-json --all-files |
8.0 ± 0.3 | 7.6 | 8.5 | 1.00 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
7.8 ± 0.1 | 7.6 | 8.2 | 1.00 |
prek-head run check-yaml --all-files |
7.8 ± 0.2 | 7.6 | 8.3 | 1.00 ± 0.03 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
7.9 ± 0.3 | 7.6 | 8.7 | 1.00 |
prek-head run check-toml --all-files |
8.3 ± 0.3 | 7.7 | 9.0 | 1.04 ± 0.05 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
8.1 ± 0.3 | 7.6 | 8.6 | 1.03 ± 0.05 |
prek-head run check-xml --all-files |
7.9 ± 0.3 | 7.5 | 8.7 | 1.00 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
12.3 ± 1.8 | 10.6 | 18.8 | 1.08 ± 0.17 |
prek-head run detect-private-key --all-files |
11.3 ± 0.6 | 10.2 | 12.4 | 1.00 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
13.4 ± 0.9 | 11.8 | 15.7 | 1.03 ± 0.09 |
prek-head run fix-byte-order-marker --all-files |
13.0 ± 0.8 | 11.6 | 15.0 | 1.00 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
5.0 ± 0.1 | 4.8 | 5.1 | 1.00 |
prek-head install-hooks |
5.1 ± 0.1 | 5.0 | 5.2 | 1.03 ± 0.03 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
5.1 ± 0.2 | 4.9 | 5.3 | 1.03 ± 0.04 |
prek-head install-hooks |
4.9 ± 0.0 | 4.9 | 5.0 | 1.00 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
25.9 ± 0.4 | 25.2 | 26.7 | 1.02 ± 0.02 |
prek-head run |
25.3 ± 0.3 | 24.8 | 26.2 | 1.00 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
5.6 ± 0.6 | 5.3 | 8.2 | 1.03 ± 0.12 |
prek-head run --files '*.json' |
5.4 ± 0.1 | 5.3 | 5.7 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
7.3 ± 0.1 | 7.1 | 7.6 | 1.00 ± 0.02 |
prek-head run --dry-run --all-files |
7.3 ± 0.1 | 7.1 | 7.7 | 1.00 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
8.6 ± 0.1 | 8.4 | 8.8 | 1.00 |
prek-head run check-hooks-apply --all-files |
8.7 ± 0.3 | 8.3 | 9.3 | 1.02 ± 0.03 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
8.5 ± 0.1 | 8.4 | 8.6 | 1.00 |
prek-head run check-useless-excludes --all-files |
8.7 ± 0.3 | 8.3 | 9.2 | 1.02 ± 0.03 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
7.4 ± 0.1 | 7.3 | 7.6 | 1.00 |
prek-head run identity --all-files |
7.6 ± 0.3 | 7.4 | 8.3 | 1.03 ± 0.04 |
Removes the deprecated
auto_updateconfig key andauto-updatecommand spelling.