fix: topic table not rendering on GitHub#4
Conversation
GitHub's markdown parser breaks table rendering when an HTML comment appears between the header separator and data rows. Moving the marker before the header keeps the full table inside the START/END block. Also update sync-topics.sh to include the header rows in table_block so regeneration doesn't strip them.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe ChangesTopics table marker and header fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
What & why
GitHub's markdown parser breaks table rendering when an HTML comment sits
between the header separator and data rows. Both README.md and
docs/CONVENTIONS.md had
<!-- TOPICS:START -->in that position, so thetopic tables rendered as raw text instead of a table.
Closes #1
Changes
README.md,docs/CONVENTIONS.md: moved<!-- TOPICS:START -->tobefore the table header row, so the full table is inside the marker block
scripts/sync-topics.sh: added the header rows (| Prefix | Topic |and|--------|-------|) intotable_blockso regeneration doesn't strip themSummary by CodeRabbit
Documentation
Chores