Draft
Add callback-driven step rejection/retry for physical constraint handling in stiff3#34
stiff3#34Conversation
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/51809c26-e83e-4103-89a1-179085fde8ef Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/51809c26-e83e-4103-89a1-179085fde8ef Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/51809c26-e83e-4103-89a1-179085fde8ef Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/51809c26-e83e-4103-89a1-179085fde8ef Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/51809c26-e83e-4103-89a1-179085fde8ef Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ivan-pi/stiff3/sessions/51809c26-e83e-4103-89a1-179085fde8ef Co-authored-by: ivan-pi <21085643+ivan-pi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add mode for guiding ODE integrator to physical values
Add callback-driven step rejection/retry for physical constraint handling in May 9, 2026
stiff3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stiff3previously letsolouteither continue or abort integration, but had no way to mark an accepted step as physically invalid (e.g., positivity violation) and retry with a smaller step. This PR adds a DASSL-like communication path so callers can reject accepted steps and drive the integrator toward physically admissible states.Callback contract extension (
irtrn)irtrn = 0: keep accepted step (unchanged)irtrn = -1: reject accepted step and retry with reduced step sizeirtrn < -1: interrupt integration (existing behavior)Core integrator retry/backtracking flow
irtrn = -1, the solver now:x,y, cached RHS/Jacobian context),Documentation and regression coverage
soloutreturn-code semantics.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either: