docs(waves): correct fast cumulative-power recipient - #295
Open
Simon-McIntosh wants to merge 1 commit into
Open
Conversation
The ion-state power_inside_fast and power_inside_fast_n_phi descriptions said the absorbed power lands on the thermal population, duplicating the power_inside_thermal siblings and contradicting their own names. Unit W and all structural metadata are unchanged.
Simon-McIntosh
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
August 22, 2026 12:21
DavidPCoster
approved these changes
Aug 22, 2026
SimonPinches
approved these changes
Aug 23, 2026
simpla-fusion
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294
The ion-state
power_inside_fastandpower_inside_fast_n_phidescriptionssaid the absorbed power lands on the thermal population, duplicating the
power_inside_thermalsiblings and contradicting both their own names and theneighbouring
power_density_fast.This corrects the recipient wording in both. Unit
Wand every type,coordinate, path and dimensional attribute are unchanged; the XSD still parses.
Note:
waves_coherent_wave_profiles_1d_ioncarries the same wording on itsspecies-level
power_inside_fastpair. Left out of scope here to match theissue — happy to include it if you would prefer one change.
📚 Documentation preview 📚: https://imas-data-dictionary--295.org.readthedocs.build/en/295/
📚 XML Diff 📚: https://scdimasdictionnarysa.z6.web.core.windows.net/pr-295/index.html