[discussion-265] Add a list of event in the Summary IDS - #292
Open
imbeauf wants to merge 1 commit into
Open
Conversation
imbeauf
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
olivhoenen,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
August 20, 2026 10:17
DavidPCoster
approved these changes
Aug 20, 2026
simpla-fusion
approved these changes
Aug 23, 2026
| <int name="h_l" description="H to L mode transition">2</int> | ||
| <int name="sawtooth" description="Sawtooth crash">3</int> | ||
| <int name="disruption" description="Disruption">4</int> | ||
| <int name="heating" description="Start of auxiliary heating">5</int> |
Collaborator
There was a problem hiding this comment.
Do we want to distinguish by heating system (we will use EC for breakdown, so does that count as the start of auxiliary heating?). Do we also want to record the increase/decrease/end of heating as well?
Collaborator
There was a problem hiding this comment.
Only if there is interest. W.r.t start of auxiliary heating, this is something that was captured/defined in ITPA DBs (under the ONTIME variable), without more info there but maybe @ksunhee8 knows more?
Collaborator
Author
There was a problem hiding this comment.
Decision
- we drop the duration field
- we remove the "heating" identifier
qsthayashi
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://imas-data-dictionary--292.org.readthedocs.build/en/292/
📚 XML Diff 📚: https://scdimasdictionnarysa.z6.web.core.windows.net/pr-292/index.html