Improvement/imas 3243 - #288
Open
imbeauf wants to merge 2 commits into
Open
Conversation
…NAS IDS : add the antenna/module structure and remove antenna/phase
… element species injected per NBI unit)
imbeauf
requested review from
DavidPCoster,
SimonPinches,
aksinghh,
medvedevsyu,
olivhoenen,
pankin,
qsthayashi,
simpla-fusion and
yegakjh
as code owners
August 19, 2026 08:46
DavidPCoster
approved these changes
Aug 19, 2026
simpla-fusion
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves an old IMAS JIRA ticket https://jira.iter.org/browse/IMAS-3243?filter=-1
This is to harmonize the Pulse schedule with the descriptions used in the NBI and IC_ANTENNAS IDSs:
For ICRH: add an antenna/module structure and remove the antenna/phase node
For NBI: replace the previous possibly multi-molecular species mixture by a single species per unit (and a single element species) to match the NBI IDS
📚 Documentation preview 📚: https://imas-data-dictionary--288.org.readthedocs.build/en/288/
📚 XML Diff 📚: https://scdimasdictionnarysa.z6.web.core.windows.net/pr-288/index.html