Fix npm vulns client vscode#140
Merged
Merged
Conversation
Resolved 13 advisories (8 moderate, 5 high) reported by `npm audit` via `npm audit fix`. Lock-file-only update; package.json unchanged. TypeScript compile verified. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aneshlya
force-pushed
the
fix-npm-vulns-client-vscode
branch
from
54e708d to
c016eda
Compare
The hardcoded `MSBuild <generated>.sln` invocations break when CMake selects a non-VS generator on the GitHub Actions windows-latest image (now shipping VS 18 + MSBuild 18), since no .sln gets produced. Switch to `cmake --build --config Release`, which works with any generator. Also pass -DCMAKE_BUILD_TYPE=Release so single-config generators (Ninja, Makefiles) produce Release binaries. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.