Draft
[WIP] Fix all jobs in WebRTC workflow for successful builds#7515
Conversation
…code, VP9 preference - Remove duplicate redraw on input (WebRTCWindowSystem.cpp) - Draw coalescing (BitmapWindowSystem.cpp) - Input (mouse event) coalescing (BitmapWindowSystem.cpp) - JS requestAnimationFrame coalescing / throttling (webrtcstreamer.js) - Async encoder thread (PeerConnectionManager.cpp/.h) - Data channel low-latency mode (webrtcstreamer.js) - Reduced startup delay (500ms -> 250ms) (WebRTCWindowSystem.cpp) - VP9 codec preference over VP8 (webrtcstreamer.js)
sends zero playout delay in every RTP packet's header extension when adaptation is necessary, drops resolution rather than framerate prevents WebRTC's autonomous resolution scaling; Replaced playoutDelayHint with jitterBufferTarget = 0
…channel reliability
…faster download. General cleanup.
- Prepend depot_tools to PATH and run win_tools.bat on Windows - Disable protobuf constinit on Apple to fix Xcode 15.4 build
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
…to copilot/fix-webrtc-workflow-jobs # Conflicts: # cpp/open3d/t/io/file_format/FileASSIMP.cpp
…ot_tools bootstrap
Copilot stopped work on behalf of
ssheorey due to an error
July 3, 2026 01:09
Copilot stopped work on behalf of
ssheorey due to an error
July 3, 2026 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Wno-changes-meaningwith-fpermissiveinwebrtc_common.cmake; removed0003patch (invalid#pragma GCC diagnostic ignored "-Wchanges-meaning")fix_protobuf_port_cc_apple()inapply_webrtc_patches.sh— Python script that directly guardsfixed_address_empty_stringinport.ccwith#if defined(__APPLE__)to dropPROTOBUF_CONSTINITon Xcode 15.4webrtc_build.sh(skip symlinks that fail on Windows); explicitCMAKE_MAKE_PROGRAMto VSninja.exebefore adding depot_tools to PATH inwebrtc.yml; post-extraction validation offetch.bat/gn.batwebrtc.ymlfor this PR branch (can be removed after verification)action_required. A maintainer must either approve them at https://github.com/isl-org/Open3D/actions/runs/28631254935, or manually trigger viaworkflow_dispatchon thecopilot/fix-webrtc-workflow-jobsbranch at https://github.com/isl-org/Open3D/actions/workflows/webrtc.yml