Skip to content

Fix minimatch security audit - #648

Closed
melroy89 wants to merge 1 commit into
isaacs:mainfrom
melroy89:fix_security_audit
Closed

Fix minimatch security audit#648
melroy89 wants to merge 1 commit into
isaacs:mainfrom
melroy89:fix_security_audit

Conversation

@melroy89

Copy link
Copy Markdown
minimatch  10.0.0 - 10.2.2
Severity: high
minimatch has ReDoS: matchOne() combinatorial backtracking via multiple non-adjacent GLOBSTAR segments - https://github.com/advisories/GHSA-7r86-cg39-jmmj
minimatch ReDoS: nested *() extglobs generate catastrophically backtracking regular expressions - https://github.com/advisories/GHSA-23c5-xmqv-rm74

@luc-LMZ

luc-LMZ commented Apr 9, 2026

Copy link
Copy Markdown

It will be really good to have this merged

@melroy89

Copy link
Copy Markdown
Author

It will be really good to have this merged

I agree of course..

@chipach

chipach commented Jul 27, 2026

Copy link
Copy Markdown

@isaacs - Any change this could get merged, pretty please?

@danifandinonearpod

Copy link
Copy Markdown

Hi, with the last audit errors, the idea is use minimatch 10.2.6

@isaacs

isaacs commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Do package managers not update transitive deps with an update command anymore? What the hell. The update is allowed by the server range. These noisy PRs and pleading comments are super annoying. Go tell your package manager to do its job.

@isaacs isaacs closed this Jul 27, 2026
@isaacs

isaacs commented Jul 27, 2026

Copy link
Copy Markdown
Owner

I’m 100% not going to accept a PR that updates the lock file and nothing else. That is a giant pile of red flags.

@melroy89
melroy89 deleted the fix_security_audit branch July 28, 2026 00:39
@melroy89

melroy89 commented Jul 28, 2026

Copy link
Copy Markdown
Author

Do package managers not update transitive deps with an update command anymore? What the hell. The update is allowed by the server range. These noisy PRs and pleading comments are super annoying. Go tell your package manager to do its job.

No they don't. Especially not when there is a dependency of a dependency. And/or when you use pnpm etc.

Not sure why the lock file is part of the npm package (git repo is fine of course).

@isaacs

isaacs commented Jul 28, 2026

Copy link
Copy Markdown
Owner

No they don't.

Have you tried running npm update? Or just deleting the lockfile and reinstalling (which is what npm update does)?

Not sure why the lock file is part of the npm package

It's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants