Skip to content

Update Compass tutorial doc#6134

Open
sameerchavan0027 wants to merge 5 commits into
isaac-sim:developfrom
sameerchavan0027:sc/compass-nurec-patch
Open

Update Compass tutorial doc#6134
sameerchavan0027 wants to merge 5 commits into
isaac-sim:developfrom
sameerchavan0027:sc/compass-nurec-patch

Conversation

@sameerchavan0027

Copy link
Copy Markdown

Update Compass training doc with gifs and proper links

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 11, 2026
@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR rewrites the COMPASS tutorial page to include NuRec asset overviews, animated GIF grids for Real2Sim/XGRIDS/training examples, and updated links pointing to the real2sim/isaaclab_3.0 branch. Six new Git LFS assets and a block of custom CSS are added to support the layout.

  • The RST document is substantially expanded with structured list-table GIF grids, properly linked headings for Real2Sim and XGRIDS assets, and a new Training Examples section.
  • Five new GIF assets are correctly referenced; one (wormhole.gif, ~10.4 MB) is added but never used in the document.
  • New CSS classes (.nurec-gif-cover, .nurec-gif-contain) apply object-fit/object-position to the <figure> wrapper rather than the inner <img>, so the cropping and fitting behavior will not render as intended.

Confidence Score: 3/5

The documentation changes are largely correct, but the CSS targeting mismatch means the GIF grid images will not display with the intended aspect-ratio cropping, which is the primary visual feature introduced by this PR.

The CSS classes nurec-gif-cover and nurec-gif-contain are placed on figure elements via Sphinx :class:, but object-fit and object-position only take effect on replaced elements such as img. The images will render without the intended 16:9 cropping or object-fit behavior. Additionally, wormhole.gif (~10.4 MB) is committed via LFS but referenced nowhere, adding dead weight to the repository.

docs/source/_static/css/custom.css needs the selectors updated to target img elements inside the figure classes. docs/source/_static/policy_deployment/03_compass_with_NuRec/wormhole.gif should be removed or linked if it is actually needed.

Important Files Changed

Filename Overview
docs/source/policy_deployment/03_compass_with_NuRec/compass_navigation_policy_with_NuRec.rst Major rewrite: adds NuRec asset overview, GIF grids for Real2Sim/XGRIDS/training examples, and updated links pointing to the real2sim/isaaclab_3.0 branch of COMPASS.
docs/source/_static/css/custom.css Adds .nurec-gif-grid and related CSS classes; object-fit/object-position are placed on figure elements (via Sphinx :class:) where they have no effect — the selectors need to target the inner img instead.
docs/source/_static/policy_deployment/03_compass_with_NuRec/wormhole.gif ~10.4 MB LFS asset added but never referenced in the RST document; likely an accidental inclusion.
docs/source/_static/policy_deployment/03_compass_with_NuRec/galileo.gif New LFS asset referenced in the Real2Sim Assets table.
docs/source/_static/policy_deployment/03_compass_with_NuRec/living_room.gif New LFS asset referenced in the Real2Sim Assets table.
docs/source/_static/policy_deployment/03_compass_with_NuRec/wormhole_with_sim_objects.gif New LFS asset referenced in the XGRIDS Assets table.
docs/source/_static/policy_deployment/03_compass_with_NuRec/galileo_g1_training.gif New LFS asset referenced in the Training Examples table.
docs/source/_static/policy_deployment/03_compass_with_NuRec/xgrid_wormhole_carter_training.gif New LFS asset referenced in the Training Examples table.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    RST["compass_navigation_policy_with_NuRec.rst"]
    CSS["custom.css\n(.nurec-gif-* classes)"]

    RST -->|"list-table :class: nurec-gif-grid"| Grid["HTML table.nurec-gif-grid"]
    RST -->|".. figure:: :class: nurec-gif-cover"| Fig["HTML figure.nurec-gif-cover"]
    Fig --> Img["img src='galileo.gif'"]

    CSS -->|"object-fit: cover applied to..."| Fig
    CSS -.->|"object-fit has no effect on figure"| Fig
    CSS -.->|"should target"| Img

    RST -->|referenced| G1["galileo.gif (LFS)"]
    RST -->|referenced| LR["living_room.gif (LFS)"]
    RST -->|referenced| WS["wormhole_with_sim_objects.gif (LFS)"]
    RST -->|referenced| GT["galileo_g1_training.gif (LFS)"]
    RST -->|referenced| XT["xgrid_wormhole_carter_training.gif (LFS)"]
    RST -. "not referenced" .-> W["wormhole.gif (LFS ~10.4 MB)"]
Loading

Reviews (1): Last reviewed commit: "Update compass docs with assets and prop..." | Re-trigger Greptile

Comment on lines +1 to +3
version https://git-lfs.github.com/spec/v1
oid sha256:b23ab980c9ead551433bbc469850528887e15d96b5c06be76e2c7deccc2b84c8
size 6913566

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unreferenced LFS asset added

wormhole.gif (~10.4 MB) is committed via Git LFS but is never referenced in the RST document. The RST uses wormhole_with_sim_objects.gif for the XGRIDS section; wormhole.gif is not linked anywhere. This adds dead weight to the repository without serving any documentation purpose.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread docs/source/_static/css/custom.css Outdated
Comment on lines +136 to +150
.nurec-gif-cover,
.nurec-gif-contain {
aspect-ratio: 16 / 9;
display: block;
object-position: center;
width: 100%;
}

.nurec-gif-cover {
object-fit: cover;
}

.nurec-gif-contain {
object-fit: contain;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 object-fit on <figure> has no effect

In Sphinx, the :class: option on a .. figure:: directive applies the class to the <figure> wrapper element, not to the <img> inside it. The CSS properties object-fit and object-position are only defined for replaced elements (e.g., <img>, <video>), so setting them on <figure> has no visual effect. The images will not be cropped or fitted as intended. To fix this, the selectors should target figure.nurec-gif-cover img and figure.nurec-gif-contain img.

wormhole.gif was committed but never referenced in the RST document.
The XGRIDS section uses wormhole_with_sim_objects.gif instead.

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation Review — COMPASS Tutorial Update

Thanks for improving the COMPASS NuRec tutorial with visual assets and better structure! The content expansion is valuable. A few issues need attention before merge:

🚨 CI Failures

Both failing CI checks are caused by issues in this PR:

  1. Broken Links check — The COMPASS handbook URL returns 404 (see inline comment).
  2. Pre-commit (codespell)segway on line 45 is flagged by codespell as a misspelling of segue. Since this is the company name "Segway" (Segway Robotics), you'll need to add it to the codespell ignore list (.codespellrc or similar) or check how other docs in this repo handle brand names that collide with common words.

Summary

Severity Count
🔴 Must fix (CI blockers) 2
🟡 Should fix 1
🟢 Nit 1

Overall the doc restructuring, GIF assets (properly LFS-tracked), and CSS additions look good. The custom CSS is well-scoped with .nurec-gif-* class prefixes, which avoids unintended side effects on other pages.

stays in sync with the NuRec support branch.
This page gives a short overview of the supported NuRec assets and example COMPASS training clips. For
installation, asset registration, training, evaluation, export, and ROS 2 deployment instructions, see the
`COMPASS handbook <https://github.com/NVlabs/COMPASS/blob/real2sim/isaaclab_3.0/docs/handbook/workflows/nurec_real2sim.md>`_.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CI Blocker — Broken link (404)

This URL returns 404:

https://github.com/NVlabs/COMPASS/blob/real2sim/isaaclab_3.0/docs/handbook/workflows/nurec_real2sim.md

The branch real2sim/isaaclab_3.0 doesn't appear to exist on the COMPASS repo (or the path has changed). This also fails the "Check for Broken Links" CI job.

Please verify the correct branch name and path. If the branch hasn't been pushed yet, consider linking to a commit SHA or the repo root until it's available.


**Galileo**

| Embodiment: `Nova Carter [wheeled robot] <https://robotics.segway.com/nova-carter/>`_

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CI Blocker — codespell false positive

codespell flags segwaysegue here. Since this is the brand name Segway Robotics, you'll need to tell codespell to ignore it.

Check the repo's codespell config (likely .pre-commit-config.yaml or a .codespellrc/setup.cfg section) for an ignore-words-list and add segway there. Other Isaac Lab docs may already handle this — worth checking.

**Wormhole**

| Embodiment: Hand-Held
| Sensor Rig: `XGRIDS PortalCam <https://www.xgrids.com/intl/portalcamp>`_ [2 x fish-eye cameras, 2 x front cameras, 1 x LiDAR]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Possible URL typo: The link target is portalcamp (with trailing "p") but the product is called "PortalCam". The correct URL is likely:

https://www.xgrids.com/intl/portalcam

Both URLs currently resolve (200), so this isn't a CI failure, but it may break if XGRIDS fixes the redirect in the future.

transform: translateX(-50%);
width: max-content;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Nit (robustness): The white-space: nowrap rule on the second line of single-grid captions could cause horizontal overflow on narrow viewports (mobile). Consider adding overflow: hidden; text-overflow: ellipsis; or testing on small screens. Low priority since docs are primarily consumed on desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant