-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Adding RigidBody USD data classes and writers #5976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vidurv-nvidia
wants to merge
10
commits into
isaac-sim:develop
Choose a base branch
from
vidurv-nvidia:vidurv/schema-frag-framework
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c61c237
feat(schemas): add rigid-body schema-fragment API
vidurv-nvidia 1a809a3
docs(schemas): mark transition shim if/else for removal post-migration
vidurv-nvidia 559c57a
refactor(schemas): annotate apply_namespaced/apply_rigid_body_propert…
vidurv-nvidia 8c2b75d
Merge branch 'develop' into vidurv/schema-frag-framework
vidurv-nvidia 2a8b8e7
fix(schemas): guard prim validity, aggregate fragment results, declar…
vidurv-nvidia fb864c0
refactor(schemas): enforce all-USD-fields invariant instead of opt-ou…
vidurv-nvidia f8a384c
Merge branch 'develop' into vidurv/schema-frag-framework
vidurv-nvidia 419e9ef
style(schemas): trim verbose comments in fragment writers
vidurv-nvidia ca465bb
docs: add Vidur Vij to CONTRIBUTORS
vidurv-nvidia b7456fc
test(schemas): drop internal plan task numbers from test section banners
vidurv-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
source/isaaclab/changelog.d/vidurv-schema-fragments.minor.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added the single-namespace schema-fragment API: :class:`~isaaclab.sim.schemas.SchemaFragment`, | ||
| the :class:`~isaaclab.sim.schemas.RigidBodyFragment` marker, and | ||
| :class:`~isaaclab.sim.schemas.UsdPhysicsRigidBodyCfg`. Each fragment carries | ||
| ``_usd_namespace`` / ``_usd_applied_schema`` metadata and a ``func`` applier so a prim can | ||
| carry rigid-body properties from multiple USD namespaces at once. | ||
| * Added :func:`~isaaclab.sim.schemas.apply_namespaced` (generic fragment writer) and | ||
| :func:`~isaaclab.sim.schemas.apply_rigid_body_properties` (applies a list of rigid-body | ||
| fragments with ``UsdPhysics.RigidBodyAPI`` as the implicit anchor). | ||
|
|
||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Changed the spawner ``rigid_props`` slot | ||
| (:attr:`~isaaclab.sim.spawners.RigidObjectSpawnerCfg.rigid_props`) to also accept a list of | ||
| :class:`~isaaclab.sim.schemas.RigidBodyFragment` fragments. Legacy single cfgs continue to | ||
| work through a transition bridge in the spawn writers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transition shim — remove at the end of the migration. A fragment list routes to
apply_rigid_body_properties; a legacy single cfg falls through to the existingdefine_/modify_writer, so current behavior is unchanged (this PR is purely additive). Collapses to one unconditionalapply_*call once call sites move to fragments and the legacy cfgs are dropped.