Skip to content

Rename UnresolvedArenaEnvGraphSpec to ArenaEnvInitialGraphSpec#783

Open
qianl-nv wants to merge 1 commit into
mainfrom
qianl/dev/graph_renaming
Open

Rename UnresolvedArenaEnvGraphSpec to ArenaEnvInitialGraphSpec#783
qianl-nv wants to merge 1 commit into
mainfrom
qianl/dev/graph_renaming

Conversation

@qianl-nv

Copy link
Copy Markdown
Collaborator

Summary

UnresolvedArenaEnvGraphSpec naming improvements

Detailed description

  • What was the reason for the change?
    -- The current naming is not informative.
  • What has been changed?
    -- UnresolvedArenaEnvGraphSpec renamed to ArenaEnvInitialGraphSpec. It captures only the initial state, vs ArenaEnvGraphSpec capturing all subtask success states additionally.
    -- Use link() instead of resolve(). This adds subtask success states and linkage between tasks and states.
  • What is the impact of this change?
    Pure naming change

Use link() instead of resolve() for the compile-to-full-graph step so the API matches the initial-graph mental model.

Signed-off-by: Qian Lin <qianl@nvidia.com>
@greptile-apps

greptile-apps Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR renames UnresolvedArenaEnvGraphSpec to ArenaEnvInitialGraphSpec and renames its resolve() method to link(), with the stated goal of making the class name more informative — it captures only the initial graph state, as opposed to ArenaEnvGraphSpec which holds all subtask success states.

  • All five changed files are consistently updated: the class definition in arena_env_graph_spec.py, its consumers in intent_compiler.py and try_environment_intent_schema.py, the test file, and the YAML fixture comment.
  • No stale references to UnresolvedArenaEnvGraphSpec or resolve() were found in any Python, YAML, or Markdown file in the repository.

Confidence Score: 5/5

This is a pure rename across 5 files with no logic changes; all references to the old name and method have been updated.

Every occurrence of UnresolvedArenaEnvGraphSpec and resolve() in Python source, tests, and YAML comments has been replaced consistently. No stale references remain anywhere in the repository, and the underlying behavior of the link() method is identical to the former resolve().

No files require special attention.

Important Files Changed

Filename Overview
isaaclab_arena/environments/arena_env_graph_spec.py Renames class UnresolvedArenaEnvGraphSpec → ArenaEnvInitialGraphSpec and method resolve() → link(); logic is unchanged.
isaaclab_arena/agentic_environment_generation/intent_compiler.py Updates import and all references from UnresolvedArenaEnvGraphSpec to ArenaEnvInitialGraphSpec; no logic changes.
isaaclab_arena/tests/test_arena_env_graph_spec.py Test names and variables updated to match the new class/method names; test coverage and assertions are unchanged.
isaaclab_arena/tests/test_data/pick_and_place_maple_table_init_env_graph.yaml YAML header comment updated to reference ArenaEnvInitialGraphSpec and link(); data unchanged.
isaaclab_arena_examples/agentic_environment_generation/try_environment_intent_schema.py Function print_unresolved_graph → print_initial_graph, import and print strings updated; no logic changes.

Sequence Diagram

sequenceDiagram
    participant Agent
    participant IntentCompiler
    participant ArenaEnvInitialGraphSpec
    participant ArenaEnvGraphSpec

    Agent->>IntentCompiler: compile(EnvironmentIntentSpec)
    IntentCompiler-->>ArenaEnvInitialGraphSpec: create(env_name, nodes, tasks, initial_state_spec)
    Note over ArenaEnvInitialGraphSpec: Holds initial state only<br/>(tasks carry kind/params, not wired)
    ArenaEnvInitialGraphSpec-->>IntentCompiler: ArenaEnvInitialGraphSpec
    IntentCompiler-->>Agent: ArenaEnvInitialGraphSpec

    Agent->>ArenaEnvInitialGraphSpec: link()
    Note over ArenaEnvInitialGraphSpec: Chains tasks → state_spec_0..N<br/>Wires initial/success_state_spec_ids
    ArenaEnvInitialGraphSpec-->>ArenaEnvGraphSpec: create(env_name, nodes, tasks, state_specs)
    ArenaEnvGraphSpec-->>Agent: Fully-wired ArenaEnvGraphSpec
Loading

Reviews (1): Last reviewed commit: "Rename UnresolvedArenaEnvGraphSpec to Ar..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant