Drop vgopath from API code generation#1479
Conversation
Use upstream `k8s.io/code-generator` (kube_codegen.sh) directly instead of synthesizing a virtual GOPATH via vgopath. The codegen tools have been module-aware for a while, so the GOPATH-style layout is no longer needed. - Remove the VGOPATH variable, install target, and version pin from the Makefile, and drop vgopath as a prerequisite of `generate` and `proto`. - Drop the mktemp + vgopath -o materialization and GOROOT/GOPATH exports from hack/update-codegen.sh; only `go mod download` remains so `go list -m` can resolve k8s.io/code-generator. Generated output (`api/`, `client-go/`, `internal/apis/`, `iri/`) is byte-identical to before. Signed-off-by: Andreas Fritzler <andreas.fritzler@sap.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR removes the ChangesRemove vgopath from code generation pipeline
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed Changes
Use upstream
k8s.io/code-generator(kube_codegen.sh) directly instead of synthesizing a virtual GOPATH via vgopath. The codegen tools have been module-aware for a while, so the GOPATH-style layout is no longer needed.generateandproto.go mod downloadremains sogo list -mcan resolve k8s.io/code-generator.Generated output (
api/,client-go/,internal/apis/,iri/) is byte-identical to before.Fixes #1478
Summary by CodeRabbit