Repository navigation
Expose partial credit options in Schemer 2.9.0 - #253
Merged
Merged
Conversation
jurei733
marked this pull request as ready for review
October 19, 2026 10:57
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 38d3547cee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jurei733
force-pushed
the
partial-credit-derived-options
branch
from
October 19, 2026 11:18
38d3547 to
f9bc275
Compare
jurei733
changed the base branch from
master
to
release/schemer-2.9.0-alpha.1
October 19, 2026 11:18
jurei733
changed the base branch from
release/schemer-2.9.0-alpha.1
to
master
October 19, 2026 12:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two independent, disabled-by-default partial-credit options to the source-parameter dialog for
SUM_SCORE,SUM_CODEandCONCAT_CODE. Sums use zero contributions; concatenation usesx, so missing partial answers remain distinguishable from real zero codes. Dialog labels and the saved parameter summary describe the correct contribution for each method.Includes German/English translations, import/export persistence and
xcombinations in the synthetic variable information used by coding generation. Generation values refresh immediately when source parameters change. The existing preview size guard counts real codes, so four binary sources retain their 16 existing combinations and expose all 80 allowed partial combinations without inventingx_x_x_x. Prepares Schemer 2.9.0 and Angular library 4.1.0.PR #251 is merged. This PR now targets
masterand contains only the additional partial-credit changes, preserving the shared Codebook and zoneless runtime.Validation:
0_x/x_0appeared in the coding generator immediately after saving, original base parameters remained unchanged, fonts loaded and no page/request errors occurred.Based on
masterafter #251. Specification PR iqb-specifications/coding-scheme#10 and Responses PR iqb-berlin/responses#141 are merged. Both@iqbspecs/coding-scheme@3.5.0and@iqb/responses@5.4.0are published. Anonymous registry downloads and both lockfile integrity values are verified. The stable Responses 5.4.0 release is based on 5.3.1 plus the targeted partial-credit changes and preserves existing JavaScript regular-expression behavior. The CI for the current head against master passes against the published packages, including browser regressions, production dependency audit, coverage tests, library build and Codebook contracts. The push CI and both CodeQL analyses also pass.Refs #167. This PR does not publish packages or deploy the Schemer.
Review follow-up for the metadata suggestion:
apiVersionidentifies the Verona Schemer communication API, not the Coding-Scheme data format. The published Verona Schemer documentation currently specifies 3.3.0; it does not define API 3.5.0. Therefore the proposed change toapiVersion: "3.5.0"is not applied. The existing3.4.1value is already present inmasterand is outside this partial-credit change; correcting that older metadata issue requires checking the implemented Verona message contract rather than copying the Coding-Scheme package version.