Skip to content

Expose partial credit options in Schemer 2.9.0 - #253

Merged
jurei733 merged 5 commits into
masterfrom
partial-credit-derived-options
Oct 19, 2026
Merged

jurei733 merged 5 commits into
masterfrom
partial-credit-derived-options

Conversation

@jurei733

@jurei733 jurei733 commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Adds two independent, disabled-by-default partial-credit options to the source-parameter dialog for SUM_SCORE, SUM_CODE and CONCAT_CODE. Sums use zero contributions; concatenation uses x, so missing partial answers remain distinguishable from real zero codes. Dialog labels and the saved parameter summary describe the correct contribution for each method.

Includes German/English translations, import/export persistence and x combinations in the synthetic variable information used by coding generation. Generation values refresh immediately when source parameters change. The existing preview size guard counts real codes, so four binary sources retain their 16 existing combinations and expose all 80 allowed partial combinations without inventing x_x_x_x. Prepares Schemer 2.9.0 and Angular library 4.1.0.

PR #251 is merged. This PR now targets master and contains only the additional partial-credit changes, preserving the shared Codebook and zoneless runtime.

Validation:

  • Full lint, 600 component tests, 6 Schemer tests, 1,341 Codebook contract checks, scheme/Ajv checks and the production-dependency graph check passed locally.
  • Production library build and packaged Schemer build passed; the Schemer build still reports bundle-size and stylesheet-resolution warnings.
  • The packaged Schemer was opened in Chrome: both options saved/exported as schema 3.5, 0_x/x_0 appeared in the coding generator immediately after saving, original base parameters remained unchanged, fonts loaded and no page/request errors occurred.
  • All 14 packed-HTML embedded-browser regressions passed in Chrome, including host updates, read-only state, rich-text saves and SOLVER expressions.
  • The rendered dialog tests use zoneless change notification and stability checks.
  • The four-binary-source regression and immediate-generation-refresh tests failed before their respective fixes and passed afterward.

Based on master after #251. Specification PR iqb-specifications/coding-scheme#10 and Responses PR iqb-berlin/responses#141 are merged. Both @iqbspecs/coding-scheme@3.5.0 and @iqb/responses@5.4.0 are published. Anonymous registry downloads and both lockfile integrity values are verified. The stable Responses 5.4.0 release is based on 5.3.1 plus the targeted partial-credit changes and preserves existing JavaScript regular-expression behavior. The CI for the current head against master passes against the published packages, including browser regressions, production dependency audit, coverage tests, library build and Codebook contracts. The push CI and both CodeQL analyses also pass.

Refs #167. This PR does not publish packages or deploy the Schemer.

Review follow-up for the metadata suggestion: apiVersion identifies the Verona Schemer communication API, not the Coding-Scheme data format. The published Verona Schemer documentation currently specifies 3.3.0; it does not define API 3.5.0. Therefore the proposed change to apiVersion: "3.5.0" is not applied. The existing 3.4.1 value is already present in master and is outside this partial-credit change; correcting that older metadata issue requires checking the implemented Verona message contract rather than copying the Coding-Scheme package version.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T12:20:41.729847Z b563d97 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 38d3547cee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jurei733
jurei733 force-pushed the partial-credit-derived-options branch from 38d3547 to f9bc275 Compare October 19, 2026 11:18
@jurei733
jurei733 changed the base branch from master to release/schemer-2.9.0-alpha.1 October 19, 2026 11:18
@jurei733
jurei733 changed the base branch from release/schemer-2.9.0-alpha.1 to master October 19, 2026 12:13
@jurei733
jurei733 merged commit 5e55d28 into master Oct 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant