Repository navigation
Fix Schemer controls at narrow container widths - #248
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea0a3c88cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| workers: 2, | ||
| use: { | ||
| browserName: 'chromium', | ||
| headless: !!process.env.CI, |
There was a problem hiding this comment.
When CI is unset, this expression evaluates to false, so the documented npm run test:schemer:responsive command launches a headed browser and fails on local headless/SSH environments without a display. This also contradicts README lines 70–72, which say --headed should be appended for a visible run; omit this override or default it to headless so the base command works everywhere.
Useful? React with 👍 / 👎.
1 participant
Schemer controls and instruction cards could overlap at 768 px or become unreachable at 375 px. The layout now supports containers from 320 CSS pixels: navigation moves above the editor on narrow screens, cards stack, and toolbars wrap. Rule cards adapt to their own width so ODER/UND remains fully visible even in the side-by-side layout at 1024 px.
Add browser regression coverage for 320, 375, 768, 1011, 1024 and 1440 px, plus resizing a narrow container inside a wide viewport. The tests check overflow, navigation, action accessibility, code models, copy/delete, and selecting and saving UND. A dedicated CI job runs the suite and retains failure screenshots and traces. Document the minimum width and reserve space for the standalone menu.
Fixes #243.
Validation on the rebased branch:
npm run test:schemer:responsive: 7 browser tests passed.npm run test:cc -- --include='**/var-coding/code-rules/*.spec.ts': 13 unit tests passed.npm run lint: passed.npm run build_sc: passed with the existing bundle budget and asset stylesheet warnings.