Repository navigation
Schemer: Nullgrenzen und numerische Regelgenerierung korrigieren - #247
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beim numerischen Zauberstab wurde eine eingegebene Grenze
0verworfen. Für den Bereich[0, 10]entstand dadurch nur die Obergrenze, sodass auch-5volle Punktzahl erhielt. Vorschau, Freigabe und Generierung verwenden jetzt eine gemeinsame Validierung und berücksichtigen0in allen vier Grenzen sowie beim exakten Vergleich.Leere, ungültige, widersprüchliche und umgekehrte Bereiche lassen sich nicht mehr erzeugen. Strenge Grenzen
>und<bleiben erhalten; kombinierte Grenzen werden mit UND verknüpft. 28 zusätzliche Regressionstests prüfen die erzeugten Regeln, ihre Auswertung und den gerenderten Dialog mit der tatsächlichen Zahlenkonvertierung.Refs #242
Validierung
npm run test:coverage: 500 Bibliothekstests und 6 Schemer-Tests erfolgreich, Coverage-Grenzen erfüllt.npm run lint,npm run test:scheme,npm run test:ajv-override: erfolgreich.ngx-coding-componentsundschemer: erfolgreich. Der Schemer-Build meldet Warnungen zum initialen Bundle-Budget und zu den Stylesheets/assets/nunitosans.cssund/assets/material-icons.css.