Allow the user to specify full box name in 'netlab libvirt package'#3422
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends netlab libvirt package so the “box version” prompt can also accept boxname:version (and namespace/boxname:version) input, enabling users to override the default box name while packaging and installing a libvirt Vagrant box.
Changes:
- Added box name/version parsing + validation to support full (
namespace/box:ver) and partial (box:ver) box naming in the packaging flow. - Adjusted generated metadata filename/description when a non-default box name is used.
- Documented the supported version/name input formats in the libvirt docs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| netsim/cli/libvirt/package.py | Adds parsing/validation for boxname:version inputs and updates metadata naming based on chosen box name. |
| docs/netlab/libvirt.md | Documents the three accepted formats for specifying box name/version during packaging. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.