fix: new bundle size esm action#876
Closed
vasco-santos wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Close as Solution is in #877 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundle size action was changed in #865 to support ESM modules, which need > Node@14 but github actions currently only support Node@12 (references in the #865 description).
We are now using Docker, where we need to have
dist/index.jsin the module to check the bundle size. While this file will always exist on a ESM build via https://github.com/mikeal/ipjs, it might not exist every time on a regular aegir build with CJS like ipfs/js-ipfs-utils#137 and multiformats/js-multiaddr#206 which have their bundle size ci job failing.The proposal with this PR is to add a new bundle size action for ESM purposes, keeping the previous one without docker. Given we already use this in https://github.com/achingbrain/uint8arrays I am separating this in aegir in 2 PRs, one to add ESM action, then update uint8arrays and finally revert regular action.
This will also mean that CJS running action will be faster as there is no need to have the extra Docker container setup for checking the bundle size.