Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rumple now returns a raster on the same voxel grid as canopy cover, PAI, and FHD. Each cell uses canopy maxima and its eight neighbors to calculate surface area with the Jenness method.
Adds optional interpolation to fill missing canopy heights before calculating rumple. Use
interpolation="linear","cubic", or"nearest"; the default leaves gaps unfilled. Observed heights are preserved, and the height threshold still applies. This also works with tiled output, where larger gaps may need a wider buffer.Includes tiled GeoTIFF output, docs, tests, and an updated notebook map. In the notebook, linear interpolation fills 30,499 missing rumple cells and increases coverage from 96.6% to 99.6%.
Validation: 152 tests passed, with one existing slow integration test skipped. CI passes on Python 3.11, 3.12, and 3.13. The notebook ran end to end and the docs built successfully.
Also updates the PDAL pin so CI keeps the installed 3.5.x bindings instead of downgrading to 3.4.5.
This overlaps #54, which uses a different calculation. This version builds the canopy surface from column maxima and uses the Jenness surface-area method.