Conversation
Signed-off-by: Mark Anderson <mark.anderson@outsystems.com>
Comment on lines
48
to
49
| if (enableCordova) { | ||
| logger.info('Found Cordova Plugins: Including iOS Cordova Support'); |
Contributor
There was a problem hiding this comment.
Minor: should this log message be tweaked since now cordova support may exist even if there are no Cordova Plugins?
Comment on lines
44
to
45
| if (enableCordova) { | ||
| logger.info('Found Cordova Plugins: Including Android Cordova Support'); |
Contributor
There was a problem hiding this comment.
Equivalent (minor) comment: should this log message be tweaked since now cordova support may exist even if there are no Cordova Plugins?
| ); | ||
| } | ||
|
|
||
| const enableCordova = cordovaPlugins.length > 0; |
Contributor
There was a problem hiding this comment.
@markemer Missing a check for config.app.forceCordova here I think?
Member
Author
There was a problem hiding this comment.
Good catch. How'd that one sneak by?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change Type
Rationale / Problems Fixed
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments