Repository navigation
ci: separate native builds into Android and iOS #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
82c31e4
ci: separate native builds into Android and iOS
OS-pedrogustavobilro dc1a36f
ci: correct for pnpm
OS-pedrogustavobilro acf2f05
ci: stick with macos-15 for now
OS-pedrogustavobilro 85673f4
Merge branch 'main' into ci/verify-separate-android-ios
OS-pedrogustavobilro d9f53db
ci: native build of example-app-spm
OS-pedrogustavobilro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| name: 'Prepare Example app' | ||
| description: 'Does necessary pre-work for the example app to compile natively' | ||
|
|
||
| inputs: | ||
| app-dir: | ||
| description: 'Path to the example app directory' | ||
| required: false | ||
| default: './example-app' | ||
|
|
||
| runs: | ||
| using: 'composite' | ||
| steps: | ||
| - name: 'Build plugin' | ||
| working-directory: ./plugin | ||
| shell: bash | ||
| run: pnpm run build | ||
| - name: 'Build Web example app' | ||
| working-directory: ${{ inputs.app-dir }} | ||
| shell: bash | ||
| run: pnpm run build | ||
| - name: 'Sync example app native platforms' | ||
| working-directory: ${{ inputs.app-dir }} | ||
| shell: bash | ||
| run: pnpm exec cap sync | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think building the plugin and the example app is needed here,
build-example-appneedsverify-plugin, which needsbuild-packages, which builds the plugin and both example apps, so they should be built at this point.And BTW, should we sync/build the
example-app-spmtoo?I don't think we are doing it in other plugins which has two example apps, but what's the point of having the spm variant if we are not doing anything with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally didn't reply in thread, refer to my reply on #129 (comment)