feat(signer): name the sealed key at unlock so a released signer can find it#416
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…find it A released signer is launched from a catalog spec whose process args were fixed before the operator's machine existed, so it cannot be told the sealed key path as a flag. The signer (from solana-signer v0.1.1) accepts the path at unlock instead; this is the host half of that contract. - SignerChannel.Unlock and the routed signer carry a keyPath, and the MCP channel sends it alongside the passphrase (left out when empty, so a signer launched with its own --key is unaffected). - mountSigner names the sealed key at <data-dir>/signers/<name>.key and fails at mount, with the path and the remedy, when it is absent, rather than letting the signer surface a lower-level open error from inside a mount. - flynn auth set signer/<name> stores the signer passphrase at the vault ref mountSigner reads. It was rejected before as an unknown model provider, so the command the mount step tells you to run now works.
ion-alpha-dev
force-pushed
the
feat/signer-key-at-unlock-host
branch
from
July 15, 2026 12:11
fb9cb38 to
81e779f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Complete the host side of the operator-to-signer credential path so a signer launched from a catalog spec can find and unlock its sealed key.
SignerChannel.Unlockand the routed signer now carry a key path, and the MCP channel sends it alongside the passphrase (omitted when empty, so a signer started with its own--keyis unaffected).mountSignernames the sealed key at<data-dir>/signers/<name>.keyand fails at mount, with the path and the remedy, when it is missing, instead of letting the signer surface a lower-level open error from inside a mount.flynn auth set signer/<name>stores the signer passphrase at the vault refmountSignerreads. It was rejected before as an unknown model provider, so the command the mount step points you to now works.Why
A released signer is launched from a catalog spec whose process args were fixed before the operator's machine existed, so it cannot be told the sealed key path as a flag. The signer accepts the path at unlock instead; this is the host half of that contract, and without it a catalog signer cannot locate its key.
How to verify
go test ./cmd/flynn/ ./extension/covers the new paths:auth set signer/<name>storing at the ref the mount reads, the key path travelling through unlock, and the mount failing with a named path and remedy when the sealed key is absent.Notes for reviewers
Pairs with solana-signer v0.1.1, which reads the key at unlock. An empty key path preserves the old flag-driven behavior.