Skip to content

Fix ctype.h funcs/macros in 2024/ferguson/dms.c #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcn2 merged 1 commit into from
Aug 29, 2026
Merged

Fix ctype.h funcs/macros in 2024/ferguson/dms.c #297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions 2025/ferguson/dms.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,14 @@ int main(int argc, char **argv)
if (argc == 9)
{
/*
* No. I don't make it an error if it's not ASCII. I could but since
* it's binary (either the value or not) I don't bother.
* the standard says that for the is*() and to*() functions of ctype.h
* they must be represented as an unsigned char or EOF (though the
* function takes an int). EOF is guaranteed to be a negative number but
* it is not guaranteed to be -1. We cast the args to unsigned char and
* compare that to the character we need.
*/
a = toupper(argv[4][0]=='S');
b = toupper(argv[8][0]=='W');
a = toupper((unsigned char)argv[4][0])=='S';
b = toupper((unsigned char)argv[8][0])=='W';

lat = dec(strtod(argv[1], 0), strtod(argv[2], 0), strtod(argv[3], 0), a);
lon = dec(strtod(argv[5], 0), strtod(argv[6], 0), strtod(argv[7], 0), b);
Expand All @@ -78,11 +81,7 @@ int main(int argc, char **argv)
}
else
{
/*
* No. I don't make it an error if it's not ASCII. I could but since
* it's binary (either the value or not) I don't bother.
*/
c = toupper(argv[4][0]);
c = toupper((unsigned char)argv[4][0]);
alt = dec(strtod(argv[1], 0), strtod(argv[2], 0), strtod(argv[3], 0), c=='S'||c=='W');

if(c == 'S' || c == 'N')
Expand Down