Send a usable payload from the Test connection button (#355)

README.md

@@ -620,6 +620,9 @@ sendTo('sql.0', 'getEnabledDPs', {}, function (result) {
 -->
 
 ## Changelog
+### **WORK IN PROGRESS**
+* (@GermanBluefox) Fixed "Test connection" reporting a failure for a working configuration: the request was built as a text template that could produce invalid JSON, and it left out `dbname`, `doNotCreateDatabase` and the docker settings (#355)
+
 ### **WORK IN PROGRESS**
 * (@GermanBluefox) "Record changes only" now compares the value instead of the controller's last-change timestamp, so an alias with a read converter no longer stores a row per source change (#295)
 

admin/i18n/de.json

@@ -93,5 +93,6 @@
     "Root password": "Root-Passwort",
     "Root URL": "Root-URL",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Legt die Root-URL fest, nützlich wenn phpMyAdmin hinter einem Reverse-Proxy läuft.",
-    "Statistics": "Statistik"
+    "Statistics": "Statistik",
+    "The test request arrived without a configuration": "Die Testanfrage kam ohne Konfiguration an"
 }

admin/i18n/en.json

@@ -93,5 +93,6 @@
     "Root password": "Root password",
     "Root URL": "Root URL",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.",
-    "Statistics": "Statistics"
+    "Statistics": "Statistics",
+    "The test request arrived without a configuration": "The test request arrived without a configuration"
 }

admin/i18n/es.json

@@ -93,5 +93,6 @@
     "Root password": "Contraseña de root",
     "Root URL": "URL raíz",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Define la URL raíz, útil cuando phpMyAdmin está detrás de un proxy inverso.",
-    "Statistics": "Estadísticas"
+    "Statistics": "Estadísticas",
+    "The test request arrived without a configuration": "La solicitud de prueba llegó sin configuración"
 }

admin/i18n/fr.json

@@ -93,5 +93,6 @@
     "Root password": "Mot de passe root",
     "Root URL": "URL racine",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Définit l’URL racine, utile lorsque phpMyAdmin est derrière un proxy inverse.",
-    "Statistics": "Statistiques"
+    "Statistics": "Statistiques",
+    "The test request arrived without a configuration": "La demande de test est arrivée sans configuration"
 }

admin/i18n/it.json

@@ -93,5 +93,6 @@
     "Root password": "Password di root",
     "Root URL": "URL radice",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Definisce l’URL radice, utile quando phpMyAdmin si trova dietro un reverse proxy.",
-    "Statistics": "Statistiche"
+    "Statistics": "Statistiche",
+    "The test request arrived without a configuration": "La richiesta di test è arrivata senza configurazione"
 }

admin/i18n/nl.json

@@ -93,5 +93,6 @@
     "Root password": "Root-wachtwoord",
     "Root URL": "Root-URL",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Bepaalt de root-URL, handig wanneer phpMyAdmin achter een reverse proxy draait.",
-    "Statistics": "Statistieken"
+    "Statistics": "Statistieken",
+    "The test request arrived without a configuration": "Het testverzoek kwam aan zonder configuratie"
 }

admin/i18n/pl.json

@@ -93,5 +93,6 @@
     "Root password": "Hasło roota",
     "Root URL": "Główny adres URL",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Określa główny adres URL, przydatne gdy phpMyAdmin działa za reverse proxy.",
-    "Statistics": "Statystyki"
+    "Statistics": "Statystyki",
+    "The test request arrived without a configuration": "Żądanie testu dotarło bez konfiguracji"
 }

admin/i18n/pt.json

@@ -93,5 +93,6 @@
     "Root password": "Palavra-passe de root",
     "Root URL": "URL raiz",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Define o URL raiz, útil quando o phpMyAdmin está atrás de um proxy inverso.",
-    "Statistics": "Estatísticas"
+    "Statistics": "Estatísticas",
+    "The test request arrived without a configuration": "O pedido de teste chegou sem configuração"
 }

admin/i18n/ru.json

@@ -93,5 +93,6 @@
     "Root password": "Пароль root",
     "Root URL": "Корневой URL",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "Задаёт корневой URL, полезно, когда phpMyAdmin находится за обратным прокси.",
-    "Statistics": "Статистика"
+    "Statistics": "Статистика",
+    "The test request arrived without a configuration": "Запрос на проверку пришёл без конфигурации"
 }

admin/i18n/zh-cn.json

@@ -93,5 +93,6 @@
     "Root password": "Root 密码",
     "Root URL": "根 URL",
     "Defines the root URL, useful when PhpMyAdmin is behind a reverse proxy.": "定义根 URL，当 phpMyAdmin 位于反向代理之后时很有用。",
-    "Statistics": "统计"
+    "Statistics": "统计",
+    "The test request arrived without a configuration": "测试请求未附带配置"
 }

admin/jsonConfig.json

@@ -161,11 +161,12 @@
                     "disabled": "!_alive",
                     "type": "sendTo",
                     "error": {
-                        "connect timeout": "Connection timeout"
+                        "connect timeout": "Connection timeout",
+                        "The test request arrived without a configuration": "The test request arrived without a configuration"
                     },
                     "icon": "data:image/svg+xml;base64,PHN2ZyBoZWlnaHQ9IjUxMiIgdmlld0JveD0iMCAwIDMyIDMyIiB3aWR0aD0iNTEyIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPg0KICAgIDxwYXRoIGZpbGw9ImN1cnJlbnRDb2xvciIgZD0ibTIyLjk4NSAxMy42OTJoLS4wMTl2LTEuNzQ2YS44MjIuODIyIDAgMCAwIDAtLjEzOSAxIDEgMCAwIDAgLS4wMTEtLjE0NXYtNS4zNjhhLjcwOC43MDggMCAwIDAgMC0uMTM5IDIuNjQgMi42NCAwIDAgMCAtMS42MzQtMi4xNzFjLTEuNzUtLjk1NC01LjI2OS0xLjY0NS05LjMzLTEuNjQ1cy03LjU3OS42OTEtOS4zMjkgMS42NDVhMi42NCAyLjY0IDAgMCAwIC0xLjYzNSAyLjE2Ny43ODguNzg4IDAgMCAwIDAgLjEzNWwtLjAxIDUuNTIyYTEuMDQxIDEuMDQxIDAgMCAwIC4wMi4yNTZsLS4wMSA1LjRhLjg4NS44ODUgMCAwIDAgLjAxLjE5MWwtLjAxIDUuNDU1cy0uMTE4IDEuMTkgMS43ODQgMi4yNTVjMS4zMjguNzQ0IDMuOTU2IDEuNTM1IDkuMTg5IDEuNTM1YTM3LjA5MSAzNy4wOTEgMCAwIDAgNC43MTUtLjI2NCA3Ljk5MyA3Ljk5MyAwIDEgMCA2LjI2OC0xMi45NDV6bS0xOS42NjEtNy43NzJhNC43MDYgNC43MDYgMCAwIDEgLjk4Ni0uNDk0IDIzLjExMiAyMy4xMTIgMCAwIDEgNy42ODEtMS4wODcgMjMuMTExIDIzLjExMSAwIDAgMSA3LjY4MSAxLjA4NyA0LjczOSA0LjczOSAwIDAgMSAuOTg3LjQ5NCAxLjcgMS43IDAgMCAxIC4yMzIuMjA5IDIuMjc2IDIuMjc2IDAgMCAxIC0uMzE4LjMxOCA0Ljk4NCA0Ljk4NCAwIDAgMSAtLjkuNDM4IDIzLjE0IDIzLjE0IDAgMCAxIC03LjY4MSAxLjA4NiAyMy4xNDEgMjMuMTQxIDAgMCAxIC03LjY4Mi0xLjA4NiA1LjAxOSA1LjAxOSAwIDAgMSAtLjktLjQzOCAyLjMzNCAyLjMzNCAwIDAgMSAtLjMxOC0uMzE4IDEuNzcgMS43NyAwIDAgMSAuMjMyLS4yMDl6bS0uMyAyLjY0M2MxLjM4Ny43IDQuMDA1IDEuNDA4IDguOTY4IDEuNDA4czcuNTc1LS43IDguOTY0LTEuNDA2djMuMTEyYTIuMzE2IDIuMzE2IDAgMCAxIC0uNzM3LjY0N2MtMS4xNzQuNjY0LTMuNTMgMS4yNzktOC4yMjcgMS4yNzktNC42NjkgMC03LjAyOC0uNjE2LTguMjEyLTEuMjhhMi40NTUgMi40NTUgMCAwIDEgLS43NS0uNjQ2cTAtLjAzNi0uMDEyLS4wNzJ6bTguOTc2IDE2LjMzN2MtNC42NyAwLTcuMDI5LS42MTctOC4yMTMtMS4yODFhMi40MzggMi40MzggMCAwIDEgLS43NjItLjY2MmwuMDA2LTMuMWMxLjM4OC43IDQuMDA2IDEuNDA4IDguOTY5IDEuNDA4IDEuMTE3IDAgMi4xMTItLjAzNSAzLS4xLS4wMTEuMTY3LS4wMTYuMzM1LS4wMTYuNTA1YTcuOTM4IDcuOTM4IDAgMCAwIC42MTUgMy4wNzJjLTEuMDE4LjEwMy0yLjIwOC4xNTgtMy41OTkuMTU4em0zLjQtNS43OGMtLjk3NS4wODUtMi4xLjEzNC0zLjQuMTM0LTQuNjcgMC03LjAyOS0uNjE2LTguMjEzLTEuMjhhMi40MjkgMi40MjkgMCAwIDEgLS43NjEtLjY2MmwuMDA2LTMuMWMxLjM4OC43IDQuMDA2IDEuNDA4IDguOTY5IDEuNDA4YTMwLjIyMyAzMC4yMjMgMCAwIDAgNi41MzktLjU4NSA4LjAyIDguMDIgMCAwIDAgLTMuMTQgNC4wODZ6bTcuNTgxIDguNTRhNS45ODggNS45ODggMCAwIDEgLTUuODUxLTcuMzE1Yy4wMDYtLjAxOS4wMTEtLjAzOS4wMTYtLjA1OHMuMDA5LS4wMzkuMDEyLS4wNTlhNiA2IDAgMSAxIDUuODIzIDcuNDMyeiIvPg0KICAgIDxwYXRoIGZpbGw9ImN1cnJlbnRDb2xvciIgZD0ibTE5LjYzOSAyMS45YTEgMSAwIDAgMCAxLjQxOCAxLjQxMSAyLjYyOCAyLjYyOCAwIDAgMSAzLjcyNSAwIDEgMSAwIDAgMCAxLjQxOC0xLjQxMSA0LjYyOCA0LjYyOCAwIDAgMCAtNi41NjEgMHoiLz4NCiAgICA8ZWxsaXBzZSBmaWxsPSJjdXJyZW50Q29sb3IiIGN4PSIyMi45ODUiIGN5PSIyNC44NDMiIHJ4PSIxLjY2NyIgcnk9IjEuNjc0Ii8+DQogICAgPHBhdGggZmlsbD0iY3VycmVudENvbG9yIiBkPSJtMjcuOTc5IDE5Ljc2OGE3LjA0NSA3LjA0NSAwIDAgMCAtOS45ODggMCAxIDEgMCAxIDAgMS40MTcgMS40MTIgNS4wNDUgNS4wNDUgMCAwIDEgNy4xNTQgMCAxIDEgMCAxIDAgMS40MTctMS40MTJ6Ii8+DQo8L3N2Zz4=",
                     "command": "test",
-                    "jsonData": "{\"config\": {\"dbtype\": \"${data.dbtype}\", \"port\": \"${data.port}\", \"host\": \"${data.host}\", \"user\": \"${data.user}\", \"fileName\": \"${data.fileName}\", \"password\": \"${data.password}\", \"encrypt\": ${data.encrypt}, \"rejectUnauthorized\": ${data.rejectUnauthorized}}}",
+                    "jsonData": "{\"config\": {\"dbtype\": ${JSON.stringify(data.dbtype || '')}, \"host\": ${JSON.stringify(data.host || '')}, \"port\": ${JSON.stringify(data.port || 0)}, \"user\": ${JSON.stringify(data.user || '')}, \"password\": ${JSON.stringify(data.password || '')}, \"dbname\": ${JSON.stringify(data.dbname || '')}, \"fileName\": ${JSON.stringify(data.fileName || '')}, \"encrypt\": ${JSON.stringify(!!data.encrypt)}, \"rejectUnauthorized\": ${JSON.stringify(!!data.rejectUnauthorized)}, \"doNotCreateDatabase\": ${JSON.stringify(!!data.doNotCreateDatabase)}, \"dockerMysql\": ${JSON.stringify(data.dockerMysql || null)}}}",
                     "label": "Test connection"
                 },
 

src/main.ts

@@ -1008,8 +1008,16 @@ export class SqlAdapter extends Adapter {
 
     async testConnection(msg: ioBroker.Message): Promise<void> {
         if (!msg?.message?.config) {
+            // Not a database problem: the request reached us without any settings. The admin builds
+            // the payload from a template and drops it silently when the result does not parse, so
+            // "invalid config" sent people looking at settings that were fine (#355).
             if (msg.callback) {
-                this.sendTo(msg.from, msg.command, { error: 'invalid config' }, msg.callback);
+                this.sendTo(
+                    msg.from,
+                    msg.command,
+                    { error: 'The test request arrived without a configuration' },
+                    msg.callback,
+                );
             }
             return;
         }