fix: honor empty-string metadata overrides (supersedes 9283)#9309
Merged
lstein merged 7 commits intoJun 28, 2026
Conversation
lstein
requested review from
JPPhoto,
blessedcoolant and
dunkeroni
as code owners
github-actions
Bot
added
api
python
lstein
deleted the
lstein/fix/supersede-9307/metadata-override-empty-string
branch
dunkeroni
pushed a commit
to dunkeroni/InvokeAI
that referenced
this pull request
Jun 29, 2026
…ai#9309) * fix metadata overrides with empty string values * chore(backend): ruff --------- Co-authored-by: wunianze666-netizen <wunianze666@gmail.com> Co-authored-by: Alexander Eichhorn <alex@eichhorn.dev> Co-authored-by: Jonathan <34005131+JPPhoto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR supersedes #9283, which had python formatting issues and whose author did not respond to requests for updates. The original summary follows.
Summary
This PR makes metadata overrides in
extract_metadata_from_image()honor explicitly provided empty strings instead of falling back to embedded image metadata.Problem
The helper currently uses
override or pil_image.info.get(...)for metadata, workflow, and graph overrides. That means an explicit empty-string override is treated as falsy and ignored, so the function silently falls back to the image's embedded metadata.Changes
is not Nonechecks for metadata/workflow/graph overridesVerification
python -m py_compile invokeai/app/api/extract_metadata_from_image.py tests/app/test_extract_metadata_from_image.pypytestis not available in this environment, so I could not execute the new test locally.