Skip to content

realign user API endpoints#11963

Merged
SchrodingersGat merged 12 commits into
inventree:masterfrom
matmair:refactor-user-endpoints
May 21, 2026
Merged

realign user API endpoints#11963
SchrodingersGat merged 12 commits into
inventree:masterfrom
matmair:refactor-user-endpoints

Conversation

@matmair
Copy link
Copy Markdown
Member

@matmair matmair commented May 18, 2026

realign user API endpoints to make it clearer which one are only applicable to the current user

Required Client Changes

@matmair matmair self-assigned this May 18, 2026
@matmair matmair added api Relates to the API refactor labels May 18, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 6426f51
🔍 Latest deploy log https://app.netlify.com/projects/inventree-web-pui-preview/deploys/6a0f81ea780a35000881858c
😎 Deploy Preview https://deploy-preview-11963--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 3 from production)
Accessibility: 81 (🔴 down 1 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@SchrodingersGat SchrodingersGat added breaking Indicates a major update or change which breaks compatibility User Interface Related to the frontend / User Interface labels May 18, 2026
@SchrodingersGat
Copy link
Copy Markdown
Member

@matmair I've created linked issues for the app and the python bindings - these will need to be updated too

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.74%. Comparing base (53d78be) to head (6426f51).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11963      +/-   ##
==========================================
- Coverage   91.46%   90.74%   -0.72%     
==========================================
  Files         974      974              
  Lines       50704    51315     +611     
==========================================
+ Hits        46374    46565     +191     
- Misses       4330     4750     +420     
Flag Coverage Δ
backend 89.27% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Backend Apps 90.80% <100.00%> (-0.98%) ⬇️
Backend General 93.49% <ø> (ø)
Frontend ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matmair
Copy link
Copy Markdown
Member Author

matmair commented May 19, 2026

change for inventree-python is in; I will try my hand at the app but i have not done anything in dart properly in years

@matmair
Copy link
Copy Markdown
Member Author

matmair commented May 20, 2026

@SchrodingersGat the only thing blocking the CI is the failing test that is adresses in inventree/inventree-python#303

@matmair matmair marked this pull request as ready for review May 20, 2026 22:04
@matmair matmair requested a review from SchrodingersGat as a code owner May 20, 2026 22:04
@matmair matmair added this to the 1.4.0 milestone May 21, 2026
@SchrodingersGat
Copy link
Copy Markdown
Member

@matmair do you have an urgent need for this, or is an idealistic change? This will introduce a major breaking change for any clients (i know I'll have a few to manage) - can we make this a 2.0.0?

@matmair matmair removed the breaking Indicates a major update or change which breaks compatibility label May 21, 2026
Comment thread src/backend/InvenTree/InvenTree/schema.py
@matmair
Copy link
Copy Markdown
Member Author

matmair commented May 21, 2026

@SchrodingersGat I have changed around a few things to make this non-breaking for now while still pushing new users/implementations to use the clearer structure.
I would prefer to change this as soon as possible to make the inherent filtering behavior clearer

@SchrodingersGat
Copy link
Copy Markdown
Member

I'm happy with the legacy endpoints approach.

@SchrodingersGat SchrodingersGat merged commit 9908870 into inventree:master May 21, 2026
55 of 56 checks passed
@SchrodingersGat SchrodingersGat deleted the refactor-user-endpoints branch May 21, 2026 23:44
@matmair
Copy link
Copy Markdown
Member Author

matmair commented May 21, 2026

💚 All backports created successfully

Status Branch Result
next-breaking

Questions ?

Please refer to the Backport tool documentation

johnluetke pushed a commit to johnluetke/InvenTree that referenced this pull request May 22, 2026
* realign user API endpoints to make it clearer which one are only applicable to the current user

* fix name

* bump api

* fix test

* fix reference

* fix test exception

* update ref

* reduce breakage

* re-add legacy urls till next `breaking`
@matmair matmair mentioned this pull request May 25, 2026
SchrodingersGat pushed a commit that referenced this pull request May 26, 2026
SchrodingersGat pushed a commit that referenced this pull request May 27, 2026
* realign user API endpoints (#11963)

* realign user API endpoints to make it clearer which one are only applicable to the current user

* fix name

* bump api

* fix test

* fix reference

* fix test exception

* update ref

* reduce breakage

* re-add legacy urls till next `breaking`

(cherry picked from commit 9908870)

* remove fallback

* fix style

* fix style

* fix performance test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Relates to the API refactor User Interface Related to the frontend / User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants