Focus+select the quantity input in the stock add/count/remove dialog#11539
Open
martonmiklos wants to merge 8 commits into
Open
Focus+select the quantity input in the stock add/count/remove dialog#11539martonmiklos wants to merge 8 commits into
martonmiklos wants to merge 8 commits into
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…the stock add/count/remove operation Fixes inventree#11511
martonmiklos
force-pushed
the
select_and_focus_qty_in_stock_add_count_remove
branch
from
3a5f426 to
d28b282
Compare
Member
|
@martonmiklos please address my question as above |
Member
|
@martonmiklos update? |
Contributor
Author
I will dedicate some time to InvenTree this weekend + Monday and will get this through. |
matmair
reviewed
May 25, 2026
| onOpen: () => { | ||
| setTimeout(() => { | ||
| const input = document.querySelector<HTMLInputElement>( | ||
| '#number-field-quantity, input[aria-label="number-field-quantity"]' |
Member
There was a problem hiding this comment.
Not sure if that is the best way to solve it as i can see these label changing in the future but I also do not have a better proposal; thoughts @SchrodingersGat ?
Member
There was a problem hiding this comment.
It seems like a bit of an anti-pattern to me - we should be able to set it with normal properties, not trying to introspect the DOM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial PR for review.
The selectAndFocus attribute is only propagated to the Numeric input types.
Shall I implement it for all the input types?
Should I separate them?
Maybe the implementation should be done in two PRs: one for providing the select and focus "API" and the second for the stock dialogs?
Fixes #11511