fix(conventional-commits): prevent PR commits from downgrading merge commit bump#2528
Open
ScottRobinson03 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
When a PR without a dedicated bump label is squash-merged, the merge commit's bump (derived from the PR title, e.g.
feat!:→major) is unconditionally overwritten by the highest bump from the individual pre-squash PR commits. This means afeat!:merge commit gets downgraded tominorif the individual commits only containfeat:.The fix includes the merge commit's own bump in the comparison array so that PR commit bumps can only upgrade the release type, never downgrade it.
Why
Fixes #2527
Squash-merge workflows rely on the PR title as the single source of truth for the release type. The current behaviour silently loses breaking change signals from the merge commit, causing incorrect version bumps.
Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor