Repository navigation
fix: Stdlib aliases in class context — the last 12 sweep failures - #786
Merged
Merged
Conversation
resolve_charset never consulted Stdlib, so digit/boundary-style
aliases in constraints degraded to vacuous fragments — moct-kor and
the rok-2011 maps never inserted the space before digits
("평리1동" -> "Pyeongniil-dong" instead of "Pyeongni Il-dong").
Resolving Stdlib values through the Any path also escaped their
regex fragments ([\\d] would match a literal backslash or d) —
Stdlib aliases resolve to Alias nodes, which the runtimes
interpolate raw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_charsetnever consulted Stdlib, sodigit/boundary-style aliases in constraints degraded to vacuous fragments — the digit-space insertion rules in moct-kor and both rok-2011 maps never fired ("평리1동" → "Pyeongniil-dong" instead of "Pyeongni Il-dong"). Resolving Stdlib values through the Any path would also escape their regex fragments ([\d]matching a literal backslash or d), so Stdlib aliases resolve to Alias nodes, which the runtimes interpolate raw.Sweep: 12 → 0 expected (full-corpus confirmation running). All 285 corpus maps parse; every map's own tests pass under both compilers.