Repository navigation
fix: decompose is not compose — var-kor green (sweep tail 132→38) - #784
Merged
Merged
Conversation
The grammar captures both directives under :compose; the builder dropped the value and compiled every decompose as NFC compose — var-kor's author-intended NFD output composed o+U+0306 into ŏ (U+014F) and all 94 of its sweep tests failed on invisible byte diffs. Read the captured value. var-kor: 282 examples, 0 failures (was 94).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grammar captures both
composeanddecomposedirectives under the:composekey; the DocumentBuilder dropped the captured value and compiled every decompose as NFC compose. var-kor's author-intended NFD output composed o+U+0306 into precomposed ŏ (U+014F) — all 94 of its sweep tests failed on invisible byte diffs ("kugyŏng" vs "kugyŏng" in any renderer).Reads the captured value; a spec pins
decomposeandcomposeproducing distinct Funcalls.Companion corpus repair (maps repo): var-kor's own file mixed precomposed ŏ on 3 lines with the combining form everywhere else — unified to the file-dominant combining form its tests expect.