Repository navigation
fix: charset alias resolution in class context — din-grc green (sweep 395→132) - #783
Merged
Merged
Conversation
Imported charset aliases (and local aliases composed of them) used bare in constraints or inside any(...) compiled to vacuous fragments (legacy Any(nil) parity) — din-grc's velar rules then fired word-initially (gkenke -> nkenke, 263 sweep failures). The adapter now resolves charset aliases at build time to class-semantics nodes: Stdlib values, imported library sets (Any or charset String), and local aliases composed of either — with a cycle guard and memoization; word-position aliases keep runtime Alias semantics, and unresolvable names stay vacuous in class context. Also: accept 4..8-hex \U (converter emits \U040E) and a bare \U as a literal U (un-mar's converter-corrupted output), so every corpus map parses. din-grc: 520 examples, 0 failures (was 263 failures). Sweep tail: 395 -> 132.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported charset aliases (and local aliases composed of them) used bare in constraints or inside any(...) compiled to vacuous fragments — legacy Any(nil) parity. din-grc's velar rules then fired word-initially:
γκέγκε→ "nkenke" instead of "gkenke" (263 sweep failures, the single biggest chunk of the sweep tail).The adapter now resolves charset aliases at build time to class-semantics nodes — Stdlib values, imported library sets (Any or charset String), and local aliases composed of either — with a cycle guard and memoization. Word-position aliases keep runtime Alias semantics; unresolvable names stay vacuous in class context.
Also:
\Uaccepts 4..8 hex digits (the corpus converter emits\U040E), and a bare\U(un-mar's converter-corrupted output) parses as a literal U so every corpus map loads.