test: skip corpus-dependent tests when the maps repo is absent - #23
Merged
Merged
Conversation
The Release workflow runs pytest without a maps checkout; the gallery-parity and transliterate tests hard-failed there with FileNotFoundError instead of skipping like the engine suite's map-dependent tests. Same skipif guard, same maps resolution (INTERSCRIPT_MAPS_PATH, else the sibling ../maps/maps).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release workflow runs
pytest tests/without a maps checkout — the gallery-parity and transliterate tests hard-failed there withFileNotFoundError(5 failures, blocking the v0.2.0 publish). They now skip with the same guard the engine suite's map-dependent tests use (envINTERSCRIPT_MAPS_PATH, else sibling../maps/maps).Verified in a clean simulation of the release environment (no maps sibling, env unset): 34 passed, 19 skipped, 0 failed — previously 5 failed.