fix: parallel selection mirrors Ruby Rule#max_length - #10
Merged
Merged
Conversation
The alternation ordered rules by regex-source-string length — a boundary-guarded rule (\b + char = 3+ source chars) shadowed a longer plain match. The Ruby runtime's key is from + before + after + not_before + not_after (+ priority), zero-width stdlib aliases counting 1. Measured against the Ruby parse of alalc-ara directly. Through the Ruby bridge, alalc-ara-Arab-Latn-1997: 16 failures -> 10 (word-initial hamza, ta-marbuta h/t, long-vowel classes all heal).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parallel alternation ordered rules by the length of the regex source string, so a boundary-guarded rule (
\b+ char renders longer than it matches) shadowed genuinely longer plain matches. This reproduces the Ruby runtime's exact selection key, measured against its parsed documents rather than inferred:Rule::Sub#max_length= from + before + after + not_before + not_after (+ priority), with zero-width stdlib aliases counting 1.Through the Ruby bridge against the ISC corpus: alalc-ara-Arab-Latn-1997 goes 16 failures → 10 — the word-initial hamza class (أوج → "awj"), ta-marbuta h/t (ṣūrah/ṣalāh), and long-vowel classes all heal. The remaining 10 are per-rule fine-tuning (medial hamza carriers, mas'alah-class), not selection-order.
Py test suite: my two new selection tests pass; the 5 remaining failures are the pre-existing maps-path environment set (unchanged baseline).