Mesh contact address#541
Open
Sam6734 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sam <55770131+Sam6734@users.noreply.github.com>
Signed-off-by: Sam <55770131+Sam6734@users.noreply.github.com>
✅ Deploy Preview for interlink-dev canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a per-worker “mesh contact address” to the generated mesh bootstrap script so downstream components (notably the interlink-htcondor-plugin) can identify and advertise the correct Kubernetes shadow Service endpoint for each worker, instead of relying on the shared WireGuard IP.
Changes:
- Added
MeshContactHosttoMeshScriptTemplateDataand populated it from the shadow Service’s fully-qualified DNS name. - Exported
INTERLINK_MESH_CONTACT_HOSTin the mesh script template for consumption by tooling running inside the network namespace. - Added a unit test to validate the mesh template renders the expected export line.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/virtualkubelet/virtualkubelet.go | Extends mesh template data with MeshContactHost. |
| pkg/virtualkubelet/templates/mesh.sh | Exports INTERLINK_MESH_CONTACT_HOST inside the mesh namespace script. |
| pkg/virtualkubelet/mesh.go | Populates MeshContactHost as <service>.<namespace>.svc.cluster.local. |
| pkg/virtualkubelet/mesh_template_test.go | Adds coverage to ensure the template exports the contact host variable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dask workers all use the same private WireGuard address,
10.7.0.2, so the HTCondor plugin needs a way to tell the scheduler how to reach each individual worker. This change adds each worker’s unique Kubernetes shadow service address to the generated mesh script, allowing the plugin to advertise the correct worker endpoint.interlink-hq/interlink-htcondor-plugin#32 depends on this change.