fix(docker): 🐛 simplify Dockerfile — build at startup so gui.env vars are available#867
Merged
Merged
Conversation
… are available The multi-stage build moved next build to image time, where no .env files exist on CI. NEXT_PUBLIC_* vars were undefined and Apollo defaulted to /graphql. This reverts to a single stage that: - Installs deps before setting NODE_ENV (devDeps like TypeScript are included) - Runs pnpm build at container STARTUP via CMD, when gui.env is already loaded by docker-compose - Keeps NODE_ENV=production for the Next.js build optimizations
phoebus-84
added a commit
that referenced
this pull request
Jul 2, 2026
- **chore: 🔧 new publish workflow also for tchibo branch (#809)** - **style: 🎨 lighter markdown editor (#763)** - **feat: ✨ links to projects now lead to new products page (#813)** - **feat: ✨ improve UX for unauthenticated users (#814)** - **fix: 🐛 project images editing (#817)** - **fix: 🐛 qr code disappear for projects that have it and new tabs mapping for url params (#818)** - **feat: ✨ add recyclability and repairability filters (#821)** - **feat: interfacer gui big rework phase 1 (#825)** - **fix: 🐛 migrate to mominatim for location autocomplete and lookup (#834)** - **feat(dpp): ✨ dedicated DPP detail page with prototype-matching UI (#835)** - **feat(layout): ✨ show top bar and sidebar for unauthenticated users (#836)** - **fix(nav): 🐛 Designs links to /designs, fix active state catch-all (#837)** - **feat: ✨ wire sorting orderBy and distinctPrimaryAccountableCount from backend (#838)** - **feat(dpp): ✨ redesign DPP tab to match Figma prototype (#839)** - **refactor(ui): remove redundant owner banners and fix search filters (#840)** - **refactor(tags): ♻️ 🏷️ prefix user tags with tag- to disambiguate from system classifiedAs (#841)** - **feat(project): ✨ add DPP-backed 3D model viewer (#848)** - **fix(docker): 🐛 replace broken pnpm download URL with corepack (#849)** - **fix(cards): 🐛 remove image rounded corners and allow two-line titles (#860)** - **fix(docker): 🐛 pin pnpm version to fix frozen-lockfile mismatch (#863)** - **fix: 🐛 re-add Machines tab to profile page with proper spec filtering (#861)** - **fix: 🐛 restrict manufacturability filter to designs catalog, driven by derived products (#859)** - **fix: 🐛 catalogue filters ux, remove apply button (#858)** - **fix(docker): 🐛 fix build failure — NODE_ENV blocking devDeps and transpilePackages config (#865)** - **fix(docker): 🐛 simplify Dockerfile — build at startup so gui.env vars are available (#867)** - **feat: ✨ implement feedback system (reviews + comments) in project detail pages (#862)** - **fix: 🐛 unrelated dpps in product details (#869)** - **feat: 3D viewer controls (zoom, rotate, fullscreen) and multi-CAD file support (#868)** --------- Co-authored-by: Puria Nafisi Azizi <puria@dyne.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #865 moved
next buildto Docker image build time (multi-stage). On CI, no.envfiles exist (gitignored), soNEXT_PUBLIC_*vars wereundefinedwhen inlined into the client JS bundle. Apollo defaulted to/graphql.Fix
Reverts to a single stage Dockerfile that:
NODE_ENV=production(devDeps like TypeScript are included)pnpm buildat container startup viaCMD, whengui.envis already loaded by docker-composeNODE_ENV=productionfor Next.js build optimizationsThis restores the original deployment pattern where
NEXT_PUBLIC_*vars are available duringnext buildbecause docker-compose has already loadedgui.env.Companion PR
DTECH_HSU_2025_OPS#7 — fixes
gui.env.j2to use proper Jinja2 variables instead of${BASE_URL}