Skip to content

BM/FRED: Remove kernel cmdline fred=on check and dmesg check #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongyuni wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BM/FRED: Remove kernel cmdline fred=on check and dmesg check #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions BM/fred/fred_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,13 @@ kconfig_test() {
# $1: Parameter should be support in cpuinfo
# Return: 0 for true, otherwise false
cpu_info_check() {
do_cmd "grep -q 'fred=on' '/proc/cmdline'"
local cpu_func=$1
[ -n "$cpu_func" ] || die "cpu info check name is null:$cpu_func"
grep -q "$cpu_func" /proc/cpuinfo || block_test "CPU not support:$cpu_func"
test_print_trc "/proc/cpuinfo contain '$cpu_func'"
return 0
}

# Dmesg test: Verify if FRED is initialized
dmesg_test() {
do_cmd "grep -q 'fred=on' '/proc/cmdline'"
do_cmd "dmesg | grep 'Initialize FRED on CPU'"
}

# CPUID test: Check FRED CPUID
cpuid_test() {
#CPUID.0x7.1.EAX[17] == 1
Expand All @@ -66,9 +59,6 @@ fred_test() {
kconfig)
kconfig_test
;;
dmesg)
dmesg_test
;;
cpuid)
cpuid_test
;;
Expand Down
1 change: 0 additions & 1 deletion BM/fred/tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# @hw_dep: cpuid_check 7 0 1 0 a 17 @ CPU doesn't support FRED CPUID.(EAX=07H,ECX=01H):EAX[bit 17]
# @other_dep: general_test.sh -t kconfig -k "CONFIG_X86_FRED=y" @ No kconfig CONFIG_X86_FRED=y
fred_test.sh -t kconfig
fred_test.sh -t dmesg
fred_test.sh -t cpuid
fred_test.sh -t cpuinfo
fred_test.sh -t lkgs
2 changes: 0 additions & 2 deletions BM/nmis/nmis_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ nmi_enable_test() {
do_cmd "cpuid_check 7 0 1 0 a 17"
#CPUID.0x7.1.EAX[20] == 1
do_cmd "cpuid_check 7 0 1 0 a 20"
do_cmd "grep -q 'fred=on' '/proc/cmdline'"
full_dmesg_check "contain" "Initialize FRED on CPU"
full_dmesg_check "null" "NMI without source information! Disable source reporting."
}

Expand Down
Loading