pcsclient: serialize qeidentity and tdqeidentity as JSON#498
Open
mythi wants to merge 1 commit into
Open
Conversation
_fetch_identity() sets the raw PCS response body (a JSON string) directly to the output dict which gets serialized as a string in the final JSON output file with json.dumps(). The result is that the output file cannot be deserialized as Enclave Identity V2 JSON. Similar to how TCB Info is already handled, parse Enclave Identity response before storing the PCS response into the output_json dict. This makes (td)qeidentity to look proper JSON. Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
mtomczew
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_fetch_identity() sets the raw PCS response body (a JSON string) directly to the output dict which gets serialized as a string in the final JSON output file with json.dumps().
The result is that the output file cannot be deserialized as Enclave Identity V2 JSON.
Similar to how TCB Info is already handled, parse Enclave Identity response before storing the PCS response into the output_json dict. This makes (td)qeidentity to look proper JSON.
Fixes: #497