fix(migtd/migration): restrict GetTDReport to emulation builds#970
Open
psidor99 wants to merge 1 commit into
Open
fix(migtd/migration): restrict GetTDReport to emulation builds#970psidor99 wants to merge 1 commit into
psidor99 wants to merge 1 commit into
Conversation
psidor99
force-pushed
the
fix/16709-gate-gettdreport-to-emu
branch
2 times, most recently
from
July 17, 2026 10:31
823b40e to
e3b7f4f
Compare
Contributor
|
Approach looks correct - GetTDReport is not part of any normative migration or rebinding flow in the Design Guide; all legitimate TDREPORT generation is MigTD-initiated during RA-TLS/SPDM attestation. Gating it behind AzCVMEmu at compile time is the right call. One suggestion for defense-in-depth: consider also #[cfg(feature = "AzCVMEmu")]-gating the WaitForRequestResponse::GetTdReport enum variant in data.rs and the corresponding handler in main.rs. That way the type system guarantees the code path is unreachable in production — if someone accidentally adds a new dispatch path in the future, the compiler will refuse to build rather than silently allowing it. |
GetTDReport returns a MAC-valid TDREPORT over a VMM-chosen REPORTDATA, giving the host VMM a signing oracle over MigTD's identity (sighting-16709). Combined with the rebinding TDREPORT relay this enables unauthenticated rebinding approval on a same-platform NEW MigTD (sighting-16711). No production migration or rebinding flow requires the VMM to invoke GetTDReport; all legitimate TDREPORT generation is MigTD-initiated during the RA-TLS handshake. Gate the request dispatch on the AzCVMEmu emulation feature and reject the operation as UnsupportedOperationError in production builds, removing the oracle at its source. Signed-off-by: Przemyslaw Sidor <przemyslaw.sidor@intel.com> Assisted-by: GitHub Copilot:claude-opus-4-8
psidor99
force-pushed
the
fix/16709-gate-gettdreport-to-emu
branch
from
July 22, 2026 12:21
e3b7f4f to
f45fe1e
Compare
psidor99
marked this pull request as ready for review
July 23, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetTDReport returns a MAC-valid TDREPORT over a VMM-chosen REPORTDATA, giving the host VMM a signing oracle over MigTD's identity (sighting-16709). Combined with the rebinding TDREPORT relay this enables unauthenticated rebinding approval on a same-platform NEW MigTD (sighting-16711).
No production migration or rebinding flow requires the VMM to invoke GetTDReport; all legitimate TDREPORT generation is MigTD-initiated during the RA-TLS handshake. Gate the request dispatch on the AzCVMEmu emulation feature and reject the operation as UnsupportedOperationError in production builds, removing the oracle at its source.
Assisted-by: GitHub Copilot:claude-opus-4-8