Improve NoreturnContractCheck#441
Merged
Merged
Conversation
This is to facilitate the distinction between routine exits and exceptional exits from a control flow graph.
This is being removed in favour of the type system and a more generic approach to block identification. Additionally, there may be more than one exit block in a CFG.
This fixes a bug that allowed loop control flow statements to be used inside `try finally` statements with the existance of a loop.
cirras
requested changes
May 12, 2026
cirras
requested changes
May 12, 2026
jgardn3r
force-pushed
the
no-return-except-block
branch
from
33df283 to
da15b24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoutineExittype to control flow graph typesControlFlowGraph::getExitBlockContinueandBreakaroundtry finallyRoutineExitblock is always id 0withFailMessagewithasin CFGBlockCheckerExceptionalRoutineExitto appropriateControlFlowGraphsNoreturnContractCheck