Add support for noreturn routine directive#299
Open
jgardn3r wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jgardn3r
force-pushed
the
support-noreturn
branch
from
9d74251 to
c017fff
Compare
Contributor
|
Lucky that the perfect hash function didn't need an update! P.S: don't forget to add it to the other keywords text file for generating the hash function. |
jgardn3r
force-pushed
the
support-noreturn
branch
from
c017fff to
b69ef70
Compare
fourls
requested changes
May 22, 2026
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Looks good - except for completeness let's add it to the KEYWORDS array in core/benches/benchmark_lexer.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #276.
By adding the keyword to the lexer and to the list of method directives, its support should be that of any other routine directive.