Repository navigation
Conversation
The editor signs in through Logto now, so the Google Identity Services hand-off and PUBLIC_GOOGLE_CLIENT_ID have no callers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The editor posts its ID token on every panel remount and token refresh. A changed token still signs in, and a rejected one can be retried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slice 6 (code half) of the authentication rework (
webapps/docs/auth-rework-plan.md, section 6). The identity bridge itself is console-side (decision 27): theoidc.is-auth(-dev)provider gets repointed at Logto at cutover, no data moves.Hold until the cutover: released editors still open
<profileCloudUrl>/authorizefor Google sign-in. A tag deploy of this branch breaks that for every pre-rework editor, so it must ship together with the editor release (plan, slice 8).Evidence
grep -rni "authorize\|GoogleAuth\|GOOGLE_CLIENT" srcempty; builds (build,build:webcomponent) pass;checkandeslinterror counts drop by the two deleted-file errors and gain none.feat/auth-logto,VITE_PROFILE_CLOUD_URLpointing at this build) the posted Logto token reachessignInWithCredentialwithproviderId=oidc.is-auth-dev,sub= fixture uid, no nonce; Firebase answersINVALID_IDP_RESPONSEissuer mismatch, which is the expected state until the console provider is repointed.Merge Danger
Door: one-way for released editors (Google sign-in path removed).
Blast Radius: sign-in from pre-rework editors once the tag deploy runs. Rehearsal note: the editor mounts
<profile-cloud-prod>for a local URL, so build withWEB_COMPONENT_NAME=profile-cloud-prod PUBLIC_APP_ENV=development npm run build:webcomponent.🤖 Generated with Claude Code