Repository navigation
Fix rename row overflow and rigid height in the config tree - #183
Merged
Merged
Conversation
MoltenInput's <input> doesn't set box-sizing, so it overflows its flex row by its own padding/border when the app is embedded as the shadow-less profile-cloud-web-component (no global box-sizing reset there) - pushing the cancel button onto its own line in narrow, deeply-nested rows. Also switch the row's fixed height to min-height (in em, to track the host-controlled font-size) so it can grow instead of clipping. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01619XN25FUTzqut4YbzZPQr
|
Visit the preview URL for this PR (updated for commit 10c0b63): https://profile-cloud-dev--pr183-fix-rename-row-overf-9rmwqb9v.web.app (expires Fri, 23 Oct 2026 10:47:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2a004f867edf1347070dd9beedb18755187a6d4e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
box-sizing: border-boxon the rename<input>— MoltenInput doesn't set it, so it overflowed its row and pushed the cancel button onto its own line when embedded as the shadow-less profile-cloud-web-component (no global reset there)flex-shrink: 0so it can never get squeezed outheight: 33pxtomin-height: 2emso it can grow instead of clipping, and scales with the host-controlled font size🤖 Generated with Claude Code
https://claude.ai/code/session_01619XN25FUTzqut4YbzZPQr