Repository navigation
Fix tree folders not closable when they contain the selected config - #181
Merged
Merged
Conversation
ConfigTree force-expanded every ancestor of the selected config on each recompute, so clicking a folder (including a top-level category) that held the active selection would immediately snap back open. Track folders the user explicitly closed and exclude them from the forced-expand set; the set clears when the selection actually changes to a different config, so a fresh selection still reveals its location. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01619XN25FUTzqut4YbzZPQr
|
Visit the preview URL for this PR (updated for commit 0a4a627): https://profile-cloud-dev--pr181-sukuwc-closable-tree-m0463mtk.web.app (expires Fri, 23 Oct 2026 09:15:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2a004f867edf1347070dd9beedb18755187a6d4e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigTree.svelteforce-reopened any folder that's an ancestor of the currently selected config on every reactive recompute — so closing a folder holding the active selection immediately snapped back open.manuallyClosed) and excludes them from the forced-expand set. The set clears only when the selection actually changes to a different config, so navigating to a new config still reveals its location, but toggling the folder around an already-selected config sticks.Test plan
svelte-checkpasses with no new errors introduced